more consistent underscore usage when this isn't used; more comments

src/dev/onionpancakes/chassis/compiler.clj

@@ -149,7 +149,7 @@
   clojure.lang.Compiler$NilExpr
   (attrs-compiler-expr? [_] true)
   clojure.lang.Compiler$MapExpr
-  (attrs-compiler-expr? [this] true)
+  (attrs-compiler-expr? [_] true)
   clojure.lang.Compiler$EmptyExpr
   (attrs-compiler-expr? [this]
     (attrs-type? (.getJavaClass this)))
@@ -176,33 +176,33 @@
 
 (extend-protocol CompilableForm
   dev.onionpancakes.chassis.core.OpeningTag
-  (attrs? [this] false)
-  (not-attrs? [this] true)
+  (attrs? [_] false)
+  (not-attrs? [_] true)
   (constant? [this]
     ;; Attrs is evaluated, but may not constant.
     (constant? (.-attrs this)))
-  (evaluated? [this] true)
+  (evaluated? [_] true)
   (resolved [this]
     (c/->OpeningTag (.-metadata this)
                     (.-tag this)
                     (.-head-id this)
                     (.-head-class this)
                     (resolved (.-attrs this))))
   dev.onionpancakes.chassis.core.ClosingTag
-  (attrs? [this] false)
-  (not-attrs? [this] true)
+  (attrs? [_] false)
+  (not-attrs? [_] true)
   (constant? [_] true)
   (evaluated? [_] true)
   (resolved [this] this)
   dev.onionpancakes.chassis.core.RawString
-  (attrs? [this] false)
-  (not-attrs? [this] true)
+  (attrs? [_] false)
+  (not-attrs? [_] true)
   (constant? [_] true)
   (evaluated? [_] true)
   (resolved [this] this)
   clojure.lang.MapEntry
-  (attrs? [this] false)
-  (not-attrs? [this] true)
+  (attrs? [_] false)
+  (not-attrs? [_] true)
   (constant? [this]
     (and (constant? (key this))
          (constant? (val this))))
@@ -224,8 +224,8 @@
   (resolved [this]
     (into (empty this) (map resolved) this))
   clojure.lang.Keyword
-  (attrs? [this] false)
-  (not-attrs? [this] true)
+  (attrs? [_] false)
+  (not-attrs? [_] true)
   (constant? [_] true)
   (evaluated? [_] true)
   (resolved [this] this)
@@ -235,7 +235,7 @@
     (and (not *evaluated*)
          (or (attrs-type-hinted? this)
              (attrs-invocation? this))))
-  (not-attrs? [this]
+  (not-attrs? [_]
     (boolean *evaluated*))
   ;; Lists are compilation barriers.
   ;; Not constants, not evaluated.
@@ -258,7 +258,7 @@
                (or (attrs-type-hinted? (key entry))
                    (attrs-compiler-binding? (val entry)))
                false))))
-  (not-attrs? [this]
+  (not-attrs? [_]
     (boolean *evaluated*))
   (constant? [_]
     (boolean *evaluated*))
@@ -276,8 +276,8 @@
   ;; Constable catches Strings, constant Numbers
   ;; (not mutable accumulator Numbers), and a bit more.
   java.lang.constant.Constable
-  (attrs? [this] false)
-  (not-attrs? [this] true)
+  (attrs? [_] false)
+  (not-attrs? [_] true)
   (constant? [_] true)
   (evaluated? [_] true)
   (resolved [this] this)
@@ -292,8 +292,8 @@
   (evaluated? [_] true)
   (resolved [this] this)
   nil
-  (attrs? [this] true)
-  (not-attrs? [this] false)
+  (attrs? [_] true)
+  (not-attrs? [_] false)
   (constant? [_] true)
   (evaluated? [_] true)
   (resolved [_] nil))

src/dev/onionpancakes/chassis/core.clj

@@ -243,7 +243,7 @@
       (replace "'" "'")))
 
 (defn escape-attribute-value
-  "Escapes an attribute value string. Escapes &, <, >, \", and '."
+  "Escape as an attribute value string. Escapes &, <, >, \", and '."
   {:tag String}
   ([] "")
   ([x]
@@ -300,8 +300,8 @@
 (extend-protocol AttributeValueFragment
   clojure.lang.Keyword
   (attribute-value-fragment [this]
-    (if-let [ns (namespace this)]
-      (let [ns-frag   (escape-attribute-value-fragment ns)
+    (if-let [ns-str (namespace this)]
+      (let [ns-frag   (escape-attribute-value-fragment ns-str)
             name-frag (escape-attribute-value-fragment (.getName this))
             sb        (doto (StringBuilder.)
                         (.append ns-frag)
@@ -353,7 +353,7 @@
     ;; and false has a fragment value of nil.
     (if this "" nil))
   nil
-  (attribute-value-fragment [this] nil))
+  (attribute-value-fragment [_] nil))
 
 ;; Opening Tag
 
@@ -727,6 +727,9 @@
 (defn make-opening-tag
   {:tag OpeningTag}
   [metadata ^clojure.lang.Keyword head attrs]
+  ;; The index of the first '#' is the anchor.
+  ;; The index of the first '.' is tested whether it's before or after the anchor.
+  ;; If before, check for another '.' after the anchor.
   (let [head-ns   (namespace head)
         head-name (.getName head)
         pound-idx (.indexOf head-name 35 #_(int \#))
@@ -815,8 +818,11 @@
   ([value & more]
    (RawString. (apply str value more))))
 
-(def raw
-  "Alias for raw-string."
+(def ^{:arglists (:arglists (meta #'raw-string))}
+  raw
+  "Wraps value as an unescaped string.
+
+  Alias for raw-string."
   raw-string)
 
 ;; Token impl
@@ -831,7 +837,7 @@
       (replace ">" "&gt;")))
 
 (defn escape-text
-  "Escapes a text string. Escapes &, <, and >."
+  "Escape as a text string. Escapes &, <, and >."
   {:tag String}
   ([] "")
   ([x]
@@ -1377,26 +1383,26 @@
 
 (extend-protocol Node
   clojure.lang.ISeq
-  (branch? [this] true)
+  (branch? [_] true)
   (children [this] this)
   clojure.core.Eduction
-  (branch? [this] true)
+  (branch? [_] true)
   (children [this] this)
   clojure.lang.IDeref
-  (branch? [this] true)
+  (branch? [_] true)
   (children [this]
     ;; Note: adds an additional depth to the search stack.
     [(.deref this)])
   clojure.lang.Fn
-  (branch? [this] true)
+  (branch? [_] true)
   (children [this]
     ;; Note: adds an additional depth to the search stack.
     [(this)])
   Object
-  (branch? [this] false)
+  (branch? [_] false)
   (children [_] nil)
   nil
-  (branch? [this] false)
+  (branch? [_] false)
   (children [_] nil))
 
 ;; Raw consts