Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to support and verify dynamic shape and rank in inputs? #20

Open
chinhuang007 opened this issue Aug 20, 2019 · 1 comment
Open

How to support and verify dynamic shape and rank in inputs? #20

chinhuang007 opened this issue Aug 20, 2019 · 1 comment

Comments

@chinhuang007
Copy link
Contributor

ONNX allows a tensor-type to have no shape (which means that even the rank is unknown). A tensor type may have a shape, in which case its rank is known. Each dimension may itself be a statically known constant or unknown. This causes Tensorflow backend converter issues when the conversion logic is based on the input rank or shape. Not sure if this applies to other converters. Would be nice to come up with common solutions.

@chinhuang007
Copy link
Contributor Author

The current assumption is the input rank must be known and shape can be unknown. All backend converters should have support and unit tests for unknown input shapes. Since ONNX doesn't provide standard tests, the Tensorflow backend converter team created own tests, https://github.com/onnx/onnx-tensorflow/blob/master/test/backend/test_dynamic_shape.py, as a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant