Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add --max-throughput to CLI and expose it to runtimes #28

Open
jeremyfowers opened this issue Dec 1, 2023 · 0 comments
Open

Proposal: Add --max-throughput to CLI and expose it to runtimes #28

jeremyfowers opened this issue Dec 1, 2023 · 0 comments
Labels
enhancement New feature or request p2 Low priority

Comments

@jeremyfowers
Copy link
Collaborator

Description

The goal is to enable users to artificially limit throughput to the desired number of invocations per second. Note: Turnkey does not use the batch size selected by the user to adjust the IPS as the batch size may not always be known.

--max-throughput should be an argument of Turnkey's CLI.

Discussion

The benchmarking help page will get very long if we add a lot of benchmarking specific flags. This, --iterations, --num-threads/processes, etc. Consider hiding these behind some kind of "advanced benchmarking options"?
@jeremyfowers jeremyfowers added enhancement New feature or request p2 Low priority labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request p2 Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremyfowers