Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gradle to 8.1.2 and add support for kotlin and kapt #627

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Upgrade gradle to 8.1.2 and add support for kotlin and kapt #627

merged 2 commits into from
Nov 3, 2023

Conversation

aanorbel
Copy link
Member

Proposed Changes

  • Upgrade gradle to 8.1.2
  • Add support for kotlin and kapt to serve as base for writing kotlin code moving forward

@aanorbel aanorbel added enhancement cleanup priority/high chore routine tasks that must be done, but require little active brain power labels Oct 24, 2023
@aanorbel aanorbel requested a review from bassosimone October 24, 2023 20:53
bassosimone
bassosimone approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 but a test is failing and we should take a look

@aanorbel
Copy link
Member Author

aanorbel commented Nov 3, 2023

Some tests fail randomly. its an issue I need to look into.

@aanorbel aanorbel merged commit 7deb8bf into master Nov 3, 2023
5 checks passed
@aanorbel aanorbel deleted the chore/gradle-kotlin-upgrade branch November 3, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
chore routine tasks that must be done, but require little active brain power cleanup enhancement priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanorbel @bassosimone