Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery use in SSAI Pulse Plugin #53

Open
coderfin opened this issue Oct 4, 2016 · 0 comments
Open

jQuery use in SSAI Pulse Plugin #53

coderfin opened this issue Oct 4, 2016 · 0 comments

Comments

@coderfin
Copy link

coderfin commented Oct 4, 2016

There is a problem with the way that jQuery is being handled and used with the ssai pulse plugin.

https://github.com/ooyala/html5-common/blob/master/js/utils/InitModules/InitOOJQuery.js.
Line 8:
$ = window.$.noConflict(true);

Sending in true removes all jQuery variables from the global scope. This is a problem when loading jQuery plugins or even using jQuery instead of $ after the ssai pulse plugin is included on the page.

Take a look at this codpen. This shows an example without the ssai pulse plugin. Notice that both jQuery and $ work.

Now take a look at this codepen. Only $ works not jQuery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant