From e78450a5ec5388c3015468e30ba05efddac6ccdd Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Mon, 16 Sep 2024 18:00:12 +0530 Subject: [PATCH 1/2] Playwright: fixed Tags AUT test (#17852) --- .../main/resources/ui/playwright/e2e/Pages/Tags.spec.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Tags.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Tags.spec.ts index 597049a08118..d108e2a3b324 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Tags.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Tags.spec.ts @@ -297,10 +297,14 @@ test('Classification Page', async ({ page }) => { const getTags = page.waitForResponse('/api/v1/tags*'); await sidebarClick(page, SidebarItem.TAGS); await getTags; + const classificationResponse = page.waitForResponse( + `/api/v1/tags?*parent=${encodeURIComponent(NEW_CLASSIFICATION.name)}*` + ); await page .locator(`[data-testid="side-panel-classification"]`) .filter({ hasText: NEW_CLASSIFICATION.displayName }) .click(); + await classificationResponse; await expect(page.locator('.activeCategory')).toContainText( NEW_CLASSIFICATION.displayName @@ -324,10 +328,14 @@ test('Classification Page', async ({ page }) => { const getTags = page.waitForResponse('/api/v1/tags*'); await sidebarClick(page, SidebarItem.TAGS); await getTags; + const classificationResponse = page.waitForResponse( + `/api/v1/tags?*parent=${encodeURIComponent(NEW_CLASSIFICATION.name)}*` + ); await page .locator(`[data-testid="side-panel-classification"]`) .filter({ hasText: NEW_CLASSIFICATION.displayName }) .click(); + await classificationResponse; await expect(page.locator('.activeCategory')).toContainText( NEW_CLASSIFICATION.displayName From 23c6aa3ca5c413fa7ed731c1cece7308258d7c0a Mon Sep 17 00:00:00 2001 From: Ayush Shah Date: Mon, 16 Sep 2024 18:02:17 +0530 Subject: [PATCH 2/2] fix: add children to array of struct (#17850) --- .../examples/sample_data/datasets/tables.json | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/ingestion/examples/sample_data/datasets/tables.json b/ingestion/examples/sample_data/datasets/tables.json index b3a24419d2ea..7669bc8ec57e 100644 --- a/ingestion/examples/sample_data/datasets/tables.json +++ b/ingestion/examples/sample_data/datasets/tables.json @@ -1604,10 +1604,23 @@ }, { "name": "shipping_address", - "dataType": "ARRAY", - "arrayDataType": "STRUCT", - "dataTypeDisplay": "array>", - "tags": [] + "dataType": "ARRAY", + "arrayDataType": "STRUCT", + "dataTypeDisplay": "array>>", + "children": [ + { + "dataType": "STRING", + "dataTypeDisplay": "string", + "name": "type" + }, + { + "dataType": "ARRAY", + "arrayDataType": "INT", + "dataTypeDisplay": "array", + "name": "provider" + } + ], + "tags": [] }, { "name": "orders",