From 9fcaaaf2c6dc00b051ef3803e785402f6b1647cb Mon Sep 17 00:00:00 2001 From: karanh37 <33024356+karanh37@users.noreply.github.com> Date: Sat, 24 Jun 2023 17:24:40 +0530 Subject: [PATCH] fix: address feedbacks of explore lineage (#12123) * fix: feedbacks * fix: color feedbacks * fix: query page resizable panel update * fix: task feed card feedbacks * fix: unit tests * fix: spacing issue * address comments --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> --- .../ActivityFeedCard/PopoverContent.tsx | 14 +- .../TaskFeedCard/TaskFeedCard.component.tsx | 4 +- .../AddGlossary/AddGlossary.component.tsx | 2 - .../ui/src/components/AppBar/Appbar.tsx | 9 +- .../DataAssetsHeader.component.tsx | 4 +- .../EntityInfoDrawer.style.less | 2 +- .../EntityLineage/AddPipeLineModal.tsx | 2 +- .../EntityLineage/CustomNodeV1.component.tsx | 2 +- .../EntityLineage/LineageConfigModal.tsx | 2 +- .../components/EntityLineage/custom-node.less | 23 +- .../src/components/EntityList/EntityList.tsx | 2 +- .../ExploreSearchCard.interface.ts | 1 - .../ExploreSearchCard/ExploreSearchCard.tsx | 112 ++++----- .../tabs/AssetsTabs.component.tsx | 1 - .../WhatsNewModal/WhatsNewModal.styles.less | 4 +- .../RightSidebar/RightSidebar.component.tsx | 5 +- .../Task/TaskTab/TaskTab.component.tsx | 46 ++-- .../Team/TeamDetails/TeamHierarchy.tsx | 7 +- .../src/components/Users/Users.component.tsx | 39 ++-- .../EntitySummaryDetails.tsx | 13 +- .../common/PopOverCard/EntityPopOverCard.tsx | 1 - .../SummaryTagsDescription.component.tsx | 18 +- .../UserSelectableList.component.tsx | 4 +- .../UserTeamSelectableList.component.tsx | 4 +- .../common/description/Description.tsx | 3 +- .../common/description/DescriptionV1.tsx | 2 +- .../ManageButton/ManageButton.tsx | 3 +- .../recently-viewed/RecentlyViewed.tsx | 2 +- .../components/searched-data/SearchedData.tsx | 1 - .../AddQueryPage/AddQueryPage.component.tsx | 216 ++++++++++-------- .../pages/AddQueryPage/AddQueryPage.test.tsx | 11 +- .../ui/src/pages/DataInsightPage/KPIList.tsx | 18 +- .../PoliciesDetailPage/PoliciesDetailPage.tsx | 7 +- .../TableDetailsPageV1/TableDetailsPageV1.tsx | 32 ++- .../RequestDescriptionPage.tsx | 8 +- .../resources/ui/src/pages/service/index.tsx | 7 +- .../ui/src/styles/components/card.less | 7 + .../ui/src/styles/components/drawer.less | 4 + .../resources/ui/src/utils/EntityUtils.tsx | 12 +- 39 files changed, 342 insertions(+), 312 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx index eca275533885..19fc1afef0bc 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/PopoverContent.tsx @@ -12,6 +12,7 @@ */ import { Button, Popover, Space } from 'antd'; +import { ReactComponent as EditIcon } from 'assets/svg/edit-new.svg'; import { isNil, isUndefined, uniqueId } from 'lodash'; import React, { FC, useMemo, useState } from 'react'; import { useTranslation } from 'react-i18next'; @@ -210,18 +211,13 @@ const PopoverContent: FC = ({ {editCheck && ( + onClick={handleEdit} + /> )} {deleteButtonCheck ? ( diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCard.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCard.component.tsx index b07f64b06ea3..e927048f7d5d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCard.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCard.component.tsx @@ -22,8 +22,8 @@ import { isUndefined, noop } from 'lodash'; import React, { useState } from 'react'; import { useTranslation } from 'react-i18next'; import { Link } from 'react-router-dom'; +import { getNameFromFQN } from 'utils/CommonUtils'; import { - entityDisplayName, getEntityFieldDisplay, getEntityFQN, getEntityType, @@ -100,7 +100,7 @@ const TaskFeedCard = ({ data-testid="entitylink" to={prepareFeedLink(entityType, entityFQN)} onClick={(e) => e.stopPropagation()}> - {entityDisplayName(entityType, entityFQN)} + {getNameFromFQN(entityFQN)} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AddGlossary/AddGlossary.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AddGlossary/AddGlossary.component.tsx index b5e2399c2978..3b5cbed7232f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/AddGlossary/AddGlossary.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/AddGlossary/AddGlossary.component.tsx @@ -17,7 +17,6 @@ import { FormProps, useForm } from 'antd/lib/form/Form'; import ResizablePanels from 'components/common/ResizablePanels/ResizablePanels'; import { UserTag } from 'components/common/UserTag/UserTag.component'; import { UserTagSize } from 'components/common/UserTag/UserTag.interface'; -import PageLayoutV1 from 'components/containers/PageLayoutV1'; import { ENTITY_NAME_REGEX } from 'constants/regex.constants'; import { EntityReference } from 'generated/type/entityLineage'; import { FieldProp, FieldTypes } from 'interface/FormUtils.interface'; @@ -305,4 +304,3 @@ const AddGlossary = ({ }; export default AddGlossary; -PageLayoutV1; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AppBar/Appbar.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AppBar/Appbar.tsx index 67ffd8928707..eecf1f3780d3 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/AppBar/Appbar.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/AppBar/Appbar.tsx @@ -292,7 +292,7 @@ const Appbar: React.FC = (): JSX.Element => { {name} -
+
{roles.length > 0 ? getUsersRoles(roles, t('label.role-plural')) : null} {inheritedRoles.length > 0 ? getUsersRoles(inheritedRoles, t('label.inherited-role-plural')) @@ -321,6 +321,7 @@ const Appbar: React.FC = (): JSX.Element => { ) : null} ) : null} +
); }; @@ -333,6 +334,12 @@ const Appbar: React.FC = (): JSX.Element => { icon: <>, isText: true, }, + { + name: t('label.logout'), + to: '', + disabled: false, + method: onLogoutHandler, + }, ]; const searchHandler = (value: string) => { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx index a54c1d302f7a..ef599e36b7f7 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx @@ -31,7 +31,7 @@ import TierCard from 'components/common/TierCard/TierCard'; import TitleBreadcrumb from 'components/common/title-breadcrumb/title-breadcrumb.component'; import EntityHeaderTitle from 'components/Entity/EntityHeaderTitle/EntityHeaderTitle.component'; import { FQN_SEPARATOR_CHAR } from 'constants/char.constants'; -import { getDashboardDetailsPath } from 'constants/constants'; +import { DE_ACTIVE_COLOR, getDashboardDetailsPath } from 'constants/constants'; import { NO_PERMISSION_FOR_ACTION } from 'constants/HelperTextUtil'; import { EntityTabs, EntityType } from 'enums/entity.enum'; import { Container } from 'generated/entity/data/container'; @@ -474,7 +474,7 @@ export const DataAssetsHeader = ({ disabled={ !(permissions.EditAll || permissions.EditTags) } - icon={} + icon={} size="small" type="text" /> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/EntityInfoDrawer/EntityInfoDrawer.style.less b/openmetadata-ui/src/main/resources/ui/src/components/EntityInfoDrawer/EntityInfoDrawer.style.less index a3a031c325eb..8cfdf7a6fd4c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/EntityInfoDrawer/EntityInfoDrawer.style.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/EntityInfoDrawer/EntityInfoDrawer.style.less @@ -22,7 +22,7 @@ } .entity-panel-container { - margin-top: 48px; + margin-top: 60px; .ant-drawer-header { border-bottom: none; padding-bottom: 0 !important; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/AddPipeLineModal.tsx b/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/AddPipeLineModal.tsx index 30bb19c04deb..678744d12553 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/AddPipeLineModal.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/EntityLineage/AddPipeLineModal.tsx @@ -67,8 +67,8 @@ const AddPipeLineModal = ({ , ]} maskClosable={false} + open={showAddPipelineModal} title={isUndefined(selectedPipelineId) ? 'Add Pipeline' : 'Edit Pipeline'} - visible={showAddPipelineModal} onCancel={onModalCancel}>