From 499a6cfd888344357571c655f86ae735b827b01b Mon Sep 17 00:00:00 2001 From: Kayla Reopelle Date: Fri, 19 Jan 2024 09:23:13 -0800 Subject: [PATCH] Experiment with running rubocop without rake --- .github/actions/test_gem/action.yml | 2 +- .../lib/opentelemetry/instrumentation/bunny/patch_helpers.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/actions/test_gem/action.yml b/.github/actions/test_gem/action.yml index a2d7221817..e7d17dda5a 100644 --- a/.github/actions/test_gem/action.yml +++ b/.github/actions/test_gem/action.yml @@ -142,7 +142,7 @@ runs: if: "${{ inputs.rubocop == 'true' }}" run: | # 🤖 Rubocop 🤖 - bundle exec rake rubocop + bundle exec rubocop working-directory: "${{ steps.setup.outputs.gem_dir }}" - name: Build Gem diff --git a/instrumentation/bunny/lib/opentelemetry/instrumentation/bunny/patch_helpers.rb b/instrumentation/bunny/lib/opentelemetry/instrumentation/bunny/patch_helpers.rb index 501020a88b..0e10ff4a8a 100644 --- a/instrumentation/bunny/lib/opentelemetry/instrumentation/bunny/patch_helpers.rb +++ b/instrumentation/bunny/lib/opentelemetry/instrumentation/bunny/patch_helpers.rb @@ -12,11 +12,11 @@ module Bunny # For additional details around trace messaging semantics # See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md#messaging-attributes module PatchHelpers - def self.with_send_span(channel, tracer, exchange, routing_key, &block) # rubocop:disable Style/ArgumentsForwarding, Lint/RedundantCopDisableDirective + def self.with_send_span(channel, tracer, exchange, routing_key, &block) # rubocop:disable Style/ArgumentsForwarding attributes = basic_attributes(channel, channel.connection, exchange, routing_key) destination = destination_name(exchange, routing_key) - tracer.in_span("#{destination} publish", attributes: attributes, kind: :producer, &block) # rubocop:disable Style/ArgumentsForwarding, Lint/RedundantCopDisableDirective + tracer.in_span("#{destination} publish", attributes: attributes, kind: :producer, &block) # rubocop:disable Style/ArgumentsForwarding end def self.with_process_span(channel, tracer, delivery_info, properties, &block) # rubocop:disable Style/ArgumentsForwarding