Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelayedJob Rails 8.0 Compatibility Error: uninitialized constant ActiveSupport::BasicObject (NameError) #1236

Closed
arielvalentin opened this issue Nov 8, 2024 · 3 comments
Labels
help wanted Extra attention is needed instrumentation

Comments

@arielvalentin
Copy link
Collaborator

DelayedJob seems to be incompatible with Rails 8 causing our canary tests to fail.

/opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/gems/3.3.0/gems/delayed_job-2.0.6/lib/delayed/message_sending.rb:2:in `<module:Delayed>': uninitialized constant ActiveSupport::BasicObject (NameError)

  class DelayProxy < ActiveSupport::BasicObject
                                  ^^^^^^^^^^^^^
Did you mean?  BasicSocket
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/gems/3.3.0/gems/delayed_job-2.0.6/lib/delayed/message_sending.rb:1:in `<top (required)>'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundled_gems.rb:75:in `require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/gems/3.3.0/gems/delayed_job-2.0.6/lib/delayed_job.rb:3:in `<top (required)>'
	from <internal:/opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from <internal:/opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundler/runtime.rb:60:in `block (2 levels) in require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundler/runtime.rb:55:in `each'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundler/runtime.rb:55:in `block in require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundler/runtime.rb:44:in `each'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundler/runtime.rb:44:in `require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundler.rb:212:in `require'
	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/releases/test/test_helper.rb:8:in `<top (required)>'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundled_gems.rb:75:in `require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from /home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/releases/test/integration/installation_test.rb:7:in `<top (required)>'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundled_gems.rb:75:in `require'
	from /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from -e:1:in `<main>'
rake aborted!
Command failed with status (1): [/opt/hostedtoolcache/Ruby/3.3.5/x64/bin/ruby -Ilib:test:.:test:lib -e 'require "minitest/autorun"; require "test/integration/installation_test.rb"' -- ]
/opt/hostedtoolcache/Ruby/3.3.5/x64/bin/bundle:25:in `load'
/opt/hostedtoolcache/Ruby/3.3.5/x64/bin/bundle:25:in `<main>'

https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/11743544247/job/32716636494

@arielvalentin arielvalentin added instrumentation help wanted Extra attention is needed labels Nov 8, 2024
@kaylareopelle
Copy link
Contributor

Thanks for opening this issue, @arielvalentin! This PR on the DelayedJob repo might fix the problem: collectiveidea/delayed_job#1219

@arielvalentin
Copy link
Collaborator Author

I think we need to add more appraisals and pin specific supported rails versions.

Hopefully once a compatible version is released we can update the appraisals to test against rails latest.

@arielvalentin
Copy link
Collaborator Author

@kaylareopelle 4.1.13 was released with Rails 8 support. https://github.com/collectiveidea/delayed_job/blob/v4.1.13/CHANGELOG.md#4113---2024-11-08

I am going to close this issue and open a PR to update the matrices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed instrumentation
Projects
None yet
Development

No branches or pull requests

2 participants