-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for X-Ray remote sampling #714
Comments
Thanks for opening this issue. We've moved it to the contrib repo. Is there any chance you'd be interested in contributing this functionality? |
Definitely. I just don't know how much time I can dedicate to this. I'd also need a little guidance as to where it would best fit in. Should we start a new |
@gillesbergerp yes, I think that creating a new sampling directory makes sense. I think each sampler should be encapsulated in its own gem. |
I agree, that makes total sense. I'll see if I can find some time on the weekend and will reach out if I need anything. |
X-Ray falls back to "1r/s or 5% after that" sampling rule if it cannot find any matching remote rules. I thought about making that implicit in the X-Ray sampling gem but then came to the conclusion that this could be interesting as a general option as well. At the very least, it will keep the X-Ray sampling implementation less complex. What do you think? |
Please see #719 for the X-Ray gem. We'll also need adaptions in https://github.com/open-telemetry/opentelemetry-ruby (specifically here) to allow for initializing the new sampler. |
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
We have successfully integrated OpenTelemetry with various of our Java applications (with X-Ray as a backend). Luckily, the OpenTelemetry Java SDK supports an X-Ray remote sampler that periodically polls X-Ray for sampling rules and applies them based on resource attributes (service name/type/...).
It would be great if the Ruby SDK would add support for this functionality as well since it makes managing sampling across a fleet of applications much easier.
The text was updated successfully, but these errors were encountered: