Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The regex Action may be Required #104

Open
alexvonme opened this issue Jun 24, 2024 · 6 comments
Open

The regex Action may be Required #104

alexvonme opened this issue Jun 24, 2024 · 6 comments

Comments

@alexvonme
Copy link
Contributor

We may need to implement regex action for several rules to maintain consistency and to provide accurate fixes. However, the VS Code extension which we link to, and is likely to be used by most people, doesn't yet support that action. The extension developer is in the process of switching to the language server, which can be tracked under ChrisChinchilla/vale-vscode#23.

I'm opening this issue to be closed when:

  • The regex action capability is added to the extension,
  • We review the rules and decide where (if) it could be useful.
@ccoVeille
Copy link
Contributor

I'm curious to see what could be the current need of using a regexp.

I can understand how it could be used to capture pattern and playing provide things by playing with $1 $2 .…

Do you have any real life example?

@ccoVeille
Copy link
Contributor

Found this one about replacing snake case by kebab case in this post

@ccoVeille
Copy link
Contributor

But I'm curious for any example you have

@ccoVeille
Copy link
Contributor

Is there a reason to link ticket 45 in addition of 23 on vale VS Code extension ?

I'm just providing the number to do not link them, if I'm totally wrong 😅

@alexvonme
Copy link
Contributor Author

I'd argue that a lot of swap options would be much better written with regex. Take any long list for swap with repeated words, such as the Contractions.yml file here, and you'll realize that a few simple rules with regex would be much cleaner and therefore easier to expand or maintain.

@ccoVeille
Copy link
Contributor

Thanks for replying me.
I get it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants