-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CURIE support for embedded resources #34
Comments
I think it might be fairly easy to do this by adding the curie parameter to the annotation (as you showed) and modifying this method to also allow a If you want, you could try implementing it and submit a pull request for it. |
That would be very nice. Thank you. |
Yeah, I guess it would make sense also following the hypertext cache pattern. However, don't we have a semantic issue. Been a while since I read the HAL spec draft but as far as I recall the I agree the implementation must adhere to the |
The HAL spec does only specify to use a
Those CURIEs defined in the
So I think there shouldn't be a semantic problem here. This should entirely conform to the spec. |
Great - then by all means let's have support on the embedded objects as
well :-)
|
I am also not sure about the semantic issue. Therefore i began with in my reading. I will quote and comment some points from the spec draft.
For me this is a validity scope declaration about the full resource, also for CURIEs (as they are special links).
Self explanatory.
Not restricting CURIE syntax to
Well some can argue that same means semantical but not syntactical. Sadly there is some lack of examples for embedded resources with CURIEs. But i think it is perfectly valid. While writing @arucard21 replyed with similar quotes and comments. So i think we read this correctly. |
Yes, I agree with you both. Makes sense to support curies for the embedded
objects as well - certainly.
I am not actively using Java currently and there are different issues
laying around on these projects so I will reserve some time soon to get
some new releases out - this should make it in such a maintenance release.
… |
In my reading of the HAL-draft it is perfectly valid to use CURIE syntax for the link relation type of embedded properties. To serialize the following "hypertext cache pattern" JSON:
Currently someone needs to provide a fixed CURIE value for the embedded resource:
It would be nice if someone could use
@EmbeddedResource(curie = "foo", value = "bars")
(as with@Link
).The text was updated successfully, but these errors were encountered: