Merge pull request #702 from Zeit-Labs/missing-param

fix: add missing ``xblock`` parameter in `get_javascript_i18n_catalog_url` | FC-0012

CHANGELOG.rst

@@ -7,6 +7,12 @@ These are notable changes in XBlock.
 Unreleased
 ----------
 
+1.9.1 - 2023-12-22
+------------------
+
+* Fix: add ``get_javascript_i18n_catalog_url`` missing ``xblock`` parameter to match the Open edX LMS
+  XBlockI18nService.
+
 1.9.0 - 2023-11-20
 ------------------
 

xblock/__init__.py

@@ -27,4 +27,4 @@ def __init__(self, *args, **kwargs):
 # without causing a circular import
 xblock.fields.XBlockMixin = XBlockMixin
 
-__version__ = '1.9.0'
+__version__ = '1.9.1'

xblock/runtime.py

@@ -1357,10 +1357,13 @@ def strftime(self, dtime, format):  # pylint: disable=redefined-builtin
         timestring = dtime.strftime(format)
         return timestring
 
-    def get_javascript_i18n_catalog_url(self):
+    def get_javascript_i18n_catalog_url(self, block):  # pylint: disable=unused-argument
         """
         Return the URL to the JavaScript i18n catalog file.
 
+        Args:
+            block (XBlock): The block that is requesting the URL.
+
         This method returns None in NullI18nService. When implemented in
         a runtime, it should return the URL to the JavaScript i18n catalog so
         it can be loaded in frontends.

xblock/test/test_runtime.py

@@ -524,7 +524,7 @@ def assert_equals_unicode(str1, str2):
         assert_equals_unicode("10:30:17 PM", i18n.strftime(when, "TIME"))
 
         # Runtimes are expected to implement this method though.
-        assert i18n.get_javascript_i18n_catalog_url() is None, 'NullI18nService does not implement this method.'
+        assert i18n.get_javascript_i18n_catalog_url(object()) is None, 'NullI18nService does not implement this method.'
 
         # secret_service is available.
         assert self.runtime.service(self, "secret_service") == 17