-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xblock version 5.0.0 broke plugin #777
Comments
Thanks for the report. The root issue you've found looks correct to me. We've switched XBlock over from pkg_resources to importlib.metadata, and it seems that hack which worked before on pkg_resources does not apply over in importlib.metadata land. On one hand, pkg_resources is not part of the public XBlock API, so I do not consider this to be a bug in XBlock. On the other hand, it seems valuable for operators to be able to customize XBlocks without forking edx-platform, so I do want to make sure there's a "supported workaround" for that. I will spend some time this week thinking if there is a supported API we could add to XBlock for customizing blocks. In the meantime, @BrandonHBodine , let me know if you find a new workaround that works with XBlock==5.0.0. |
Following up with this, I like the idea of having an XBlock-supported way to override a block as suggested by @kdmccormick. Happy to help design / review as we are under time pressure to get a change out. |
Excellent fix for this issue @nsprenkle and @kdmccormick, thank you!
Sorry for the noise! Found your openedx/edx-platform#35325. |
We have a plugin that is replacing the default XBlock with our own implementation that was recently broken with what we believe was the removal of
pkg_resources
support here #716.We followed this post as our way of implementation https://discuss.openedx.org/t/override-default-edx-platform-xblock-mappings-without-forking/12441
Suspected root of the issue in our plugin:
The text was updated successfully, but these errors were encountered: