Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing Axim Maintained Repositories #849

Closed
7 tasks
feanil opened this issue Aug 18, 2023 · 6 comments · Fixed by openedx/xblock-sdk#312 or openedx/XBlock#664
Closed
7 tasks

Update existing Axim Maintained Repositories #849

feanil opened this issue Aug 18, 2023 · 6 comments · Fixed by openedx/xblock-sdk#312 or openedx/XBlock#664
Assignees

Comments

@feanil
Copy link
Contributor

feanil commented Aug 18, 2023

The following repositories are currently maintained by the Axim Engineering Team. They currently ping that team or members of that team for reviews on weekly maintenance PRs.

Goal: Update all the repos so that the @axim-aximprovements team gets tagged on new maintenance PRs instead.

Task

  • Update the review team to @axim-aximprovements
    • The files that need to be updated are the .github/workflows/upgrade-python-requirements.yml in each of the below repos.

Relevant Repos

Acceptance Criteria

Confirm that all repos are making automated PRs and tagging the team correctly. (You'll have to wait till the time in the cron. It should be Midnight UTC between Sunday and Monday.)

@thezaeemaanwar
Copy link

thezaeemaanwar commented Aug 23, 2023

@feanil There is no .github/workflows/upgrade-python-requirements.yml in openedx-learning repository. Shall I create a new one?

Also, I'm unable to assign the issue to myself.

@feanil
Copy link
Contributor Author

feanil commented Aug 29, 2023

@thezaeemaanwar you should be able to assign the ticket to yourself now. If a repo is missing the upgrade-python-requiremnets.yml file and has python code, yes, please create the workflow.

@ormsbee tagging you in-case you weren't running regular updates on purpose.

@ormsbee
Copy link

ormsbee commented Aug 30, 2023

No, this was neglect on my part, not intent.

@feanil
Copy link
Contributor Author

feanil commented Aug 30, 2023

Sounds good, @thezaeemaanwar lets make sure and add the upgrade job to openedx-learning.

@thezaeemaanwar
Copy link

thezaeemaanwar commented Sep 1, 2023

Hey @feanil
My PRs for this task are internally approved.
Can I merge them or do they need extra approval?

Here are the PRs:
openedx/DoneXBlock#166
openedx/openedx-learning#75
openedx-unsupported/xblock-utils#222
openedx/xblock-sdk#312
openedx/XBlock#664
openedx/xblock-in-video-quiz#138
openedx/FeedbackXBlock#16

@feanil
Copy link
Contributor Author

feanil commented Sep 1, 2023

@thezaeemaanwar if the PR is approved by someone on the team, that is sufficient for you to merge them anywhere that you have merge rights. They do not need any extra approval.

@thezaeemaanwar thezaeemaanwar added blended PR is managed through 2U's blended developmnt program and removed blended PR is managed through 2U's blended developmnt program labels Sep 5, 2023
@thezaeemaanwar thezaeemaanwar moved this from 👀 In review to ✅ Done in Aximprovements Team Sep 5, 2023
@feanil feanil closed this as completed Sep 6, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Axim Engineering Tasks Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
3 participants