Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable uploading files while an upload is in progress #2237

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

viadanna
Copy link

This PR disables the upload button and shows a spinner during uploads so continuing to click the upload button doesn't flood the LMS with requests.

What changed?

  • Disables the Upload Files button when upload starts.
  • Shows a spinner to indicate to the learner an upload is in progress.
  • Toggle both when the upload finishes or fails.

Developer Checklist

Testing Instructions

  1. Deploy this version of the xblock to a devstack or instance.
  2. Create a course and add the xblock.
  3. Edit the xblock settings to allow uploads.
  4. Go to the xblock in the LMS.
  5. Open the browser developer console and set throttling to 3G.
  6. Select a few files and click Upload files.
  7. Confirm the button is disabled and a spinner appears.
  8. Disable throttling in the developer console.
  9. Confirm the button is enabled again and the spinner disappears when the upload finishes.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@viadanna viadanna requested a review from a team as a code owner September 26, 2024 10:36
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 26, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @viadanna!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-aurora. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (42e754e) to head (ade9c4e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2237   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         195      195           
  Lines       21606    21606           
  Branches     1502     1502           
=======================================
  Hits        20576    20576           
  Misses        784      784           
  Partials      246      246           
Flag Coverage Δ
unittests 95.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Tested in local devstack
  • I read through the code

@itsjeyd itsjeyd added the product review PR requires product review before merging label Oct 11, 2024
@itsjeyd
Copy link

itsjeyd commented Oct 11, 2024

@viadanna Since this is a user-facing change it will need to go through product review. You can get that process started by creating a product proposal and pinging #wg-product-core on Slack to find a coordinator (cf. docs).

CC @kaustavb12

@pomegranited
Copy link
Contributor

@viadanna @kaustavb12 Once Product is done with their review, feel free to ping me for a CC review & merge.

@itsjeyd
Copy link

itsjeyd commented Nov 21, 2024

Hey @viadanna, checking in to see if you've had a chance yet to ping #wg-product-core on Slack to find a coordinator for the product proposal (openedx/platform-roadmap#387) for this PR?

@viadanna
Copy link
Author

@itsjeyd Yes, I did, but got no answer yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Product Review
Development

Successfully merging this pull request may close these issues.

5 participants