Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Courseware Learner Sequence pages -> micro-frontend #35803

Open
feanil opened this issue Mar 9, 2022 · 7 comments
Open

[DEPR]: Courseware Learner Sequence pages -> micro-frontend #35803

feanil opened this issue Mar 9, 2022 · 7 comments
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@feanil
Copy link
Contributor

feanil commented Mar 9, 2022

Proposal Date

2 September 2020

Ticket Acceptance Date

5 October 2020

Technology Removal Date

May 2, 2022

First Open edX Named Release Without This Functionality

O* (we will merge these changes after Nutmeg release is cut and not cherry-pick over to the release branch)

Rationale

As part of our re-platforming effort, we are replacing Django-server-side rendered frontend implementations in favor of React-based micro-frontend implementations. This ticket covers the pages related to the Learner Sequence pages (often referred to as the “courseware experience”). The announcement of the Legacy implementation’s deprecation was shared on the Open edX forum.

Removal

We are removing edx-platform's older implementation of the Django-server-side rendering of the Learner Course Sequence and Unit pages.

Replacement

We are replacing this page with the new micro-frontend-based implementation:

Deprecation

No response

Migration

No response

Additional Info

Still to-do (updated 03/29/2022)

Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-109

@feanil feanil added the depr Proposal for deprecation & removal per OEP-21 label Mar 9, 2022
@jmyatt
Copy link
Contributor

jmyatt commented Mar 29, 2022

I'm not able to edit the description of this issue, but some updated information:

Technology Removal Date
May 2, 2022

First Open edX Named Release Without This Functionality
O* (we will merge these changes after Nutmeg release is cut and not cherry-pick over to the release branch)

Still to-do (updated 03/29/2022)

@feanil
Copy link
Contributor Author

feanil commented Mar 29, 2022

Thanks @jmyatt I've updated the content.

@feanil
Copy link
Contributor Author

feanil commented Mar 29, 2022

@jmyatt I've also added you as the assignee just so we can track who to talk to about this given that it's in progress. If it should be someone else, let me know.

@mikix
Copy link
Contributor

mikix commented Apr 19, 2022

Now that #30238 landed, the only place these legacy courseware templates/views are used is for Studio's preview mode feature.

The team that owns Studio has plans to eventually upgrade that feature into a version that can use the MFE, but for now, it will continue to use the legacy view. (I've asked for a link to a ticket for tracking this, can update when I have it.)

Learners and staff can no longer access the normal legacy views though. Has to be accessed via the (staff-only) preview mode.

I'd argue that from a "feature DEPR" point of view, this could be closed. But from a "code DEPR" point of view, the code still lives on for this one feature and maybe you don't want to close. Willl leave it up to you folks, but I'd vote for closing.

@dianakhuang
Copy link
Contributor

We believe this is still blocked on getting rid of content preview, but that needs some verification.

@kdmccormick
Copy link
Member

@dianakhuang I can verify that Studio course preview is one feature (and, as far as I know, the only feature) relying on the legacy courseware sequence views.

You can see this in action by going into Studio, choosing a course, clicking into a unit editor, and and clicking "View Preview". This should bring you to a variant of the LMS running on the PREVIEW_LMS_BASE domain, which causes this conditional to return True and send you the legacy sequence view: https://github.com/openedx/edx-platform/blob/open-release/palm.1/lms/djangoapps/courseware/toggles.py#L105-L112

@kdmccormick kdmccormick transferred this issue from openedx/public-engineering Nov 7, 2024
@kdmccormick
Copy link
Member

@KristinAoki has moved Studio course preview over to the Learning MFE: openedx/frontend-app-learning#1455

Once that is confirmed as fixed, we can begin the process of removing legacy courseware logic, views, and flags entirely. The only view that should remain is the chromeless XBlock renderers, which is what the MFEs and the apps use.

@kdmccormick kdmccormick moved this from Proposed to Removing in DEPR: Deprecation & Removal Nov 7, 2024
@kdmccormick kdmccormick moved this from Removing to Blocked in DEPR: Deprecation & Removal Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Blocked
Development

No branches or pull requests

5 participants