-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restore jump nav and content width #994
base: master
Are you sure you want to change the base?
feat: Restore jump nav and content width #994
Conversation
Thanks for the pull request, @Lunyachek! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
=======================================
Coverage 56.53% 56.53%
=======================================
Files 118 118
Lines 2457 2457
Branches 654 654
=======================================
Hits 1389 1389
Misses 997 997
Partials 71 71 ☔ View full report in Codecov by Sentry. |
Hi @openedx/fed-bom! Are you still reviewing / merging OSPRs? If so this one is ready. If not, please let me know. |
Hi @openedx/2u-aperture! Would someone be able to review this for us? Along with the backport? |
Hi @mphilbrick211, Apologies in advance, Aperture are not maintainers for this MFE, so I'm not sure if we have the time and expertise to help here. |
Hi @justinhynes - it looks like Aperture is going to take it over? |
@mphilbrick211 News to me! I'll double check. 😅 |
@mphilbrick211 Apologies for the delay. I did check internally, and I was under the impression that the @openedx/2u-vanguards will be the maintainers of the Account MFE. |
Hi @openedx/2u-vanguards! Are you able to take a look at this for us? Thanks! |
Hi @openedx/2u-infinity @openedx/edx-infinity! Can someone take a look at this? It's been stalled for a bit. Thanks! |
Friendly ping on this @openedx/2u-infinity! |
Our proposal is to modify the width values of jump-nav and content to their state prior to this pull request - #784. In this pull request, the width of the jump nav was reduced, and the width of the content was increased. This results in the jump nav appearing very narrow on themes with a maximum container width. Even the phrase "Account Information" does not fit into a single line
After this small fix we'll restore previous state of the columns width, like in Palm