Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating create_caltrack_daily_design_matrix #518

Open
laurenjanicke opened this issue Nov 8, 2024 · 0 comments
Open

Updating create_caltrack_daily_design_matrix #518

laurenjanicke opened this issue Nov 8, 2024 · 0 comments

Comments

@laurenjanicke
Copy link

laurenjanicke commented Nov 8, 2024

Report installed package versions

eemeter==4.0.5
pandas==1.5.3
scipy==1.10.1
numpy==1.24.3

Describe the bug
Running create_caltrack_daily_design_matrix(meter_data, temperature_data) doesn't create any cdd or hdd columns. This bug is due to missing arguments in the call to compute_temperature_features. Below is what the current call to compute_temperature_features looks like in create_caltrack_daily_design_matrix.

```python
>>> import eemeter
>>> import pandas as pd
>>> meter_data = pd.DataFrame({"start": ..., "value": ...})
>>> temperature_data = pd.DataFrame({"temp":...})
>>> eemeter.create_caltrack_daily_design_matrix(meter_data, temperature_data)
```
temperature_features = compute_temperature_features(
        meter_data.index,
        temperature_data,
        data_quality=True,
    )

Expected behavior
Documentation says that create_caltrack_daily_design_matrix should return design_matrix – A design matrics with mean usage_per_day, hdd_30-hdd_90, and cdd_30-cdd_90 features. Below is what the call to compute_temperature_features should be.

temperature_features = compute_temperature_features(
        meter_data.index,
        temperature_data,
        heating_balance_points=range(30, 91),
        cooling_balance_points=range(30, 91),
        data_quality=True,
    )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant