You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
src/binfhe/include/rgsw-cryptoparameters.h: in RingGSWCryptoParams()
instead of "if ((method == LMKCDEY) & (numAutoKeys == 0))" there should be "if ((method == LMKCDEY) && (numAutoKeys == 0))"
FindInVector() is defined in 2 different classes: DiscreteGaussianGeneratorImpl and in BaseSampler.
src/pke/lib/encoding/packedencoding.cpp: bool PackedEncoding::Encode(): "size_t i;" is declared twice outside of the loop in this function. Should not be outside the corresponding loops
Change the name COMPRESSION_LEVEL (constants.h) to Camel case
Add either NOT_SET or INVALID_VALUE to all enums in constants.h
Add
#include "math/hal/basicint.h" // for MAX_MODULUS_SIZE
to constants.h and remove
#include "math/math-hal.h"
#include "lattice/constants-lattice.h"
Add #include "lattice/constants-lattice.h" to rlwe-cryptoparameters.h
See if we can replace the __builtin_*() functions with __FILE__, __LINE__ and __FUNCTION__ in OpenFHEException as the functions are available with gcc only - This can not be done as the macros are replaced with information from exception.h by the preprocessor at compile time.
Remove the return value (eval_key_map) from EvalSumRowsKeyGen()/EvalSumColsKeyGen() and the EvalKey parameter from EvalSumRows()/EvalSumCols()
Add "std::" to ceil(), floor(), log2(), etc. and static_cast<> where it is necessary for the return value
Replace "DCRTPoly" with "Element" in multiple files and discuss the changes with a scientist. Examples:
utils/exception.h: make all get functions const for OpenFHEException
Rename the function member PrintValue() to GetFormattedValues() and move it simple implementation to PlaintextImpl "precision". Use it in operator<<(). The function should be overloaded in CKKSPackedEncoding only. Also check doprint(), PrintParameters() and print() (in src/pke/include/metadata.h). GetFormattedValues() should stay public in case someone needs to change the precision (like in openfhe-python).
Replace sharingScheme types "additive" and "shamir" with enums
Get rid of "int"
Remove _MAKE_UNIQUE and make_unique from src/core/include/utils/memory.h and remove includes of memory.h where they are not needed
The text was updated successfully, but these errors were encountered:
instead of "if ((method == LMKCDEY) & (numAutoKeys == 0))" there should be "if ((method == LMKCDEY) && (numAutoKeys == 0))"
#include "math/hal/basicint.h" // for MAX_MODULUS_SIZE
to constants.h and remove
#include "math/math-hal.h"
#include "lattice/constants-lattice.h"
See if we can replace the__builtin_*()
functions with__FILE__, __LINE__ and __FUNCTION__
in OpenFHEException as the functions are available with gcc only - This can not be done as the macros are replaced with information from exception.h by the preprocessor at compile time.The text was updated successfully, but these errors were encountered: