-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library to vcpkg #770
Labels
new feature
New feature or request
Milestone
Comments
I am new here. Could I start with this issue?? |
We simply have to wait until all the linked PRs gets merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to #742 (comment):
To make it easier to use the library I wanted to bring the lib to vcpkg. While doing so, I noticed some areas that could be improved, mainly by trying to compile with msvc, but that only made the errors visible.
#742: The begin function could return an iterator object depending on your build settings (for example debug msvc, but you can also do this with gcc and clang).
#743: Why using compiler specific extensions when there are standard attributes?
#744: Finish refactoring that you started. Also fixes the msvc build.
#746: Detected while compiling for android.
#747: On the way to msvc support.
#748: Nicer way to define
_USE_MATH_DEFINES
. The the include order is also not important. (If i include math.h before your header your header is currently broken.)#749: Use the c++ implementation as fallback, allows msvc support.
#750: No need to rely on bash if there is an cmake builtin for it
The text was updated successfully, but these errors were encountered: