Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful upload of proof image with invalid bearer token #626

Open
monsieurtanuki opened this issue Dec 16, 2024 · 2 comments
Open

Successful upload of proof image with invalid bearer token #626

monsieurtanuki opened this issue Dec 16, 2024 · 2 comments

Comments

@monsieurtanuki
Copy link

What

In off-dart's tests, on the TEST env (.net), we try to upload a proof with an invalid bearer token (actual value: 'invalid bearer token'). It's supposed to fail, but it doesn't anymore.

Steps to reproduce the behavior:

  1. Try to upload a proof with an invalid bearer token in TEST env
  2. It works.
  3. It shouldn't.
@raphodn
Copy link
Member

raphodn commented Dec 16, 2024

Hi, since last week it's now possible to upload proofs anonymously: #595

@monsieurtanuki
Copy link
Author

Hi @raphodn!
IMHO "anonymously" and "with an incorrect bearer token" isn't exactly the same.

Anyway, it means that from now on in uploadProof for off-dart:

  • the bearer token parameter is optional
  • if the bearer token is invalid, the call will be successful (today it fails) and will consider that the owner is openfoodfacts-contributors

Is that correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants