Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save logo text (extracted using OCR in DB) #1283

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

raphael0202
Copy link
Collaborator

Save in DB in a new field logo_annotation.text the text extracted using OCR.
It's useful as we can have a much higher confidence in the logo prediction with the text included.

I also added integration to a new repository test-data, that is going to replace the use of git LFS. Unit/ML/integration tests will fetch assets from this repository.
The assets are cached locally using diskcache, so that they don't have to be downloaded again.

@raphael0202 raphael0202 requested a review from a team as a code owner October 31, 2023 16:46
robotoff/utils/download.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1283 (c5923b6) into main (e4080ca) will increase coverage by 0.04%.
The diff coverage is 89.28%.

❗ Current head c5923b6 differs from pull request most recent head 389aaaa. Consider uploading reports for the commit 389aaaa to get more accurate results

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   56.61%   56.66%   +0.04%     
==========================================
  Files          77       78       +1     
  Lines        7547     7566      +19     
==========================================
+ Hits         4273     4287      +14     
- Misses       3274     3279       +5     
Files Coverage Δ
robotoff/models.py 95.51% <100.00%> (+0.02%) ⬆️
robotoff/prediction/object_detection/core.py 50.00% <100.00%> (ø)
robotoff/utils/__init__.py 61.19% <100.00%> (ø)
robotoff/utils/cache.py 100.00% <100.00%> (ø)
robotoff/utils/download.py 100.00% <100.00%> (ø)
robotoff/utils/image.py 79.41% <80.00%> (-9.30%) ⬇️
robotoff/workers/tasks/import_image.py 30.58% <54.54%> (+0.99%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael0202 raphael0202 merged commit 2905741 into main Nov 2, 2023
6 checks passed
@raphael0202 raphael0202 deleted the add-text-to-logo branch November 2, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant