make sure qc_record.extras exists before accessing it

openforcefield · Oct 21, 2024 · 4e97f34 · 4e97f34
1 parent c8d7df8
commit 4e97f34
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/openff/bespokefit/optimizers/forcebalance/factories.py b/openff/bespokefit/optimizers/forcebalance/factories.py
@@ -71,7 +71,7 @@ def _standardize_grid_id_str(grid_id: str) -> tuple[Union[int, float]]:
 
 
 def _get_qc_record_id(qc_record):
-    return qc_record.extras["id"] if "id" in qc_record.extras else qc_record.id
+    return qc_record.extras["id"] if qc_record.extras and "id" in qc_record.extras else qc_record.id
 
 
 class _TargetFactory(Generic[T], abc.ABC):