Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies; add test build to ci #389

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Fix dependencies; add test build to ci #389

merged 4 commits into from
Oct 24, 2023

Conversation

why-not-try-calmer
Copy link
Contributor

No description provided.

mkdocs-material-extensions
added concurrency to cancel jobs with the same github ref; reverted renaming
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy reaction! It would be great to have the smoke test in place!

I would either rename the workflow or even better add a separate file.

BTW, this is one of the reasons I prefer having all deps in the requirements.txt.

@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Oct 24, 2023

Thanks for the speedy reaction! It would be great to have the smoke test in place!

I would either rename the workflow or even better add a separate file.

BTW, this is one of the reasons I prefer having all deps in the requirements.txt.

pre-commit.yml -> lint-test.yml would be ok? With different files you need to write more logic to avoid proceeding with a workflow that should not occur when the test / build fails.

@suricactus
Copy link
Collaborator

Thanks for the speedy reaction! It would be great to have the smoke test in place!
I would either rename the workflow or even better add a separate file.
BTW, this is one of the reasons I prefer having all deps in the requirements.txt.

pre-commit.yml -> lint-test.yml would be ok? With different files you need to write more logic to avoid proceeding with a workflow that should not occur when the test / build fails.

Yes, it is ok. Or lint-and-test, lint-and-build, even continuous-integration to keep it generic.

Also change the name of the workflow in line 1: name: pre-commit.

@why-not-try-calmer why-not-try-calmer changed the title Test if it builds Fix dependencies; add test build to ci Oct 24, 2023
@why-not-try-calmer
Copy link
Contributor Author

Not sure what this about though
image

@why-not-try-calmer
Copy link
Contributor Author

Ah, branch protection rules I guess. I don't have the rights to update that.

@suricactus suricactus merged commit 84cb614 into master Oct 24, 2023
2 checks passed
@suricactus suricactus deleted the lint-test branch October 24, 2023 14:57
@suricactus
Copy link
Collaborator

Still fails, interesting. It works fine locally.

@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Oct 24, 2023

@why-not-try-calmer
Copy link
Contributor Author

Ah I bet you 10 lev that it's material-insiders replacing the correct dependencies with incorrect ones.

@suricactus
Copy link
Collaborator

Ok, locally I managed to reproduce, at least for me it uses the wrong mkdocs command. We should revert installing the extensions module too, see the first paragraph https://pypi.org/project/mkdocs-material-extensions/ .

Will debug later tonight.

@why-not-try-calmer
Copy link
Contributor Author

why-not-try-calmer commented Oct 24, 2023

Ok, locally I managed to reproduce, at least for me it uses the wrong mkdocs command. We should revert installing the extensions module too, see the first paragraph https://pypi.org/project/mkdocs-material-extensions/ .

Will debug later tonight.

Okay but if it uses the wrong mkdocs command, I wonder why https://github.com/opengisch/QField-docs/actions/runs/6628670609/job/18006277873 did not fail? For me the reasoning is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants