New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml settings should use the [tool] table #242

Closed

ivanlonel opened this issue Aug 31, 2023 · 1 comment · Fixed by #243

Contributor

ivanlonel commented Aug 31, 2023

The build dependency declaration specification requires third-party tools to use the namespace tool.* in pyproject.toml, as defined in PEP518.

As such, qgis-plugin-ci settings should be under [tool.qgis-plugin-ci], not [qgis-plugin-ci] as it is now.

Example:

[tool.bandit]
skips = ["B405", "B410"]

[tool.black]
line-length = 119

[tool.isort]
line_length = 119

[tool.mypy]
show_column_numbers = true

[tool.qgis-plugin-ci]
plugin_path = "qgis_plugin_ci_testing"
github_organization_slug = "opengisch"
project_slug = "qgis-plugin-ci"

The text was updated successfully, but these errors were encountered:

Member

3nids commented Aug 31, 2023

ping @why-not-try-calmer

why-not-try-calmer linked a pull request

that will close this issue

declaring qgis-plugin-ci config under 'tool' #243

Merged

why-not-try-calmer closed this as completed in #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment