Pass authentication as a header #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously special characters in username or password crashed address parsing. Form the Authorization header value manually to allow special characters.
Gustry
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously special characters in the username or password could lead to a crash during address parsing. This pull request addresses the issue by manually forming the Authorization header value, allowing for special characters.
An alternative approach would have been to quote all special characters from the username and password using urllib.parse.quote() and then utilizing the quoted values in the URI. However, the current approach was chosen over this alternative because it eliminates the need to modify the server_url if it is provided as a parameter. Additionally, this method avoids unnecessary quote-unquote steps.
Resolves #259