Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVXIF : commit_valid asserted more than 1 clk cycle #2630

Closed
1 task done
AyoubJalali opened this issue Nov 25, 2024 · 10 comments
Closed
1 task done

CVXIF : commit_valid asserted more than 1 clk cycle #2630

AyoubJalali opened this issue Nov 25, 2024 · 10 comments
Assignees
@Gchauvon
Labels
PARAM:CVXIF CVXIF Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system

Comments

@AyoubJalali
Copy link
Contributor

Is there an existing CVA6 bug for this?

  • I have searched the existing bug issues

Bug Description

Recording to the CVXIF spec, the commit_valid should be asserted for only 1 clk cycle exactly

image

this is not the case in the CVA6 as shown in the waveform :

image
@AyoubJalali AyoubJalali added Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system PARAM:CVXIF CVXIF labels Nov 25, 2024
@fatimasaleem
Copy link
Contributor

When back-to-back instructions are being committed then it is possible to have commit_valid being set for multiple cycles.

@AyoubJalali
Copy link
Contributor Author

When back-to-back instructions are being committed then it is possible to have commit_valid being set for multiple cycles.

In this case the commit_valid asserted more than one for the same ID

@AyoubJalali
Copy link
Contributor Author

Also the spec doesn't mention ID related for commit_valid, I think we should create an issue for clarify the spec

@AyoubJalali
Copy link
Contributor Author

@JeanRochCoulon @MikeOpenHWGroup what do you think ?

@AyoubJalali
Copy link
Contributor Author

When back-to-back instructions are being committed then it is possible to have commit_valid being set for multiple cycles.

image

@fatimasaleem
Copy link
Contributor

When back-to-back instructions are being committed then it is possible to have commit_valid being set for multiple cycles.

image

I see that commit_id 1 is missing. I think that is the issue. The issue is not causing any bug currently because we really don't use the trans_id in commit stage for anything.

@AyoubJalali
Copy link
Contributor Author

I see that commit_id 1 is missing. I think that is the issue. The issue is not causing any bug currently because we really don't use the trans_id in commit stage for anything.

your right, that's another issue because the CVA6 wait the agent ready signals to send response

@AyoubJalali
Copy link
Contributor Author

and for commit_valid being set for multiple cycle for different IDs, this is not be clear in the Spec.

@AyoubJalali
Copy link
Contributor Author

I see that commit_id 1 is missing. I think that is the issue. The issue is not causing any bug currently because we really don't use the trans_id in commit stage for anything.

the issue_valid is 0 is this case so the issue_req isn't valid, so the values read isn't valid

@AyoubJalali
Copy link
Contributor Author

Fixed by #2678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gchauvon Gchauvon

Labels
PARAM:CVXIF CVXIF Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fatimasaleem @Gchauvon @AyoubJalali