-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: greeks: Sensitivities of Prices of Financial Options and Implied Volatilities #5987
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏻 @ahudde, @lrnv, @bahung - this is the review thread for the submission. All of our communications will happen here from now on. Please check the post at the top of the issue for instructions on how to generate your own review checklist. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues directly in the software repository. If you do so, please mention this thread so that a link is created (and I can keep an eye on what is happening). Please also feel free to comment and ask questions in this thread. It is often easier to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. Please feel free to ping me (@csoneson) if you have any questions or concerns. Thanks! |
Review checklist for @lrnvConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @bahungConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@ahudde could you please update the LICENSE that complies with the contents of an OSI approved software license? |
Dear @bahung thank you very much, I have changed the license to MIT license. |
Dear @lrnv, |
Hi @ahudde, posted a new issue regarding your paper ahudde/greeks#18 (comment) |
Hi all - I wanted to check in how things are going here. |
Hi @csoneson, the issue has not been solved yet. We had new discussion, and follow-up issue |
👋🏻 Happy New Year! |
Dear @csoneson, |
@ahudde - thanks for the update! Please keep us posted (I just want to make sure that the review doesn't stall and that the submission is actively worked on). |
👋🏻 @ahudde - just wanted to check in here. As mentioned, we want to make sure that submissions are actively worked on (also to respect the reviewers' time commitment), so it would be great if you could provide an estimate of when you think you can have a revised version addressing the comments above. Thanks! |
Dear @csoneson - thank you very much for your inquiry. I appreciate the reviewers and your time very much and plan to address the issues in 2-3 weeks. I'm very thankfull for you understanding! |
That's great, thank you @ahudde! |
@editorialbot generate pdf |
@csoneson Thank you very much! |
Dear @csoneson, Yours, Anselm |
Hm, I see - let me run the |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5124, then you can now move forward with accepting the submission by compiling again with the command |
@csoneson Great, thanks! |
I'm sorry @ahudde, I'm afraid I can't do that. That's something only eics are allowed to do. |
Dear @csoneson, Yours, Anselm |
That is the topic Associate Editor in Chief. They are informed and will take care of it, please be patient. |
@csoneson Great, thanks! |
@editorialbot recommend-accept |
|
|
@ahudde are those DOIs OK? |
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5136, then you can now move forward with accepting the submission by compiling again with the command |
Dear @oliviaguest, |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @ahudde (Anselm Hudde)
Repository: https://github.com/ahudde/greeks
Branch with paper.md (empty if default branch):
Version: greeks_1.4.0
Editor: @csoneson
Reviewers: @lrnv, @bahung
Archive: 10.5281/zenodo.10806607
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lrnv & @bahung, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @lrnv
📝 Checklist for @bahung
The text was updated successfully, but these errors were encountered: