-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict in documentation regarding Trip - trip_type #43
Comments
Looks like the Stoplight docs are in error. Should be one trip type. A PR can be created here https://github.com/openmobilityfoundation/mds-openapi |
I'm not sure exactly how to change this trip_type array to an enumerated value based on mode in OpenAPI. Maybe @mplsmitch @thekaveman could help advise. Also might need to edit in passenger services, car share, delivery robots, and micromobility pages. I have a |
The schema does allow only a single I think the changes would be: trip_type:
type: string Then for each of the mode-specific trip_type:
enum:
- private
- shared
- reservation
- empty |
So is
trip_type
one string or many strings in array ?https://github.com/openmobilityfoundation/mobility-data-specification/blob/2.0.0/data-types.md#trips
![image](https://private-user-images.githubusercontent.com/5707457/280212400-3610a1a7-4c5b-4722-a954-96823ce0ecd0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3OTg5NjAsIm5iZiI6MTcyMjc5ODY2MCwicGF0aCI6Ii81NzA3NDU3LzI4MDIxMjQwMC0zNjEwYTFhNy00YzViLTQ3MjItYTk1NC05NjgyM2NlMGVjZDAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMTkxMTAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjdhMmI0YmI5NmViZGU2OGJlYjUyMzM1YzQ0ZDVmOTM2ZGFiNDcyNTQ1ZGU5MmI0NThlZWU0MGYyNWFmNGNlOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.RtesCXVMMtvq18q0cxMl_dIknEe6Z5PjldHHXXatWcg)
https://github.com/openmobilityfoundation/mobility-data-specification/blob/2.0.0/modes/micromobility.md#trip-type
![image](https://private-user-images.githubusercontent.com/5707457/280212525-9d55fd7f-0cac-46f0-9f47-cd60abae8635.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3OTg5NjAsIm5iZiI6MTcyMjc5ODY2MCwicGF0aCI6Ii81NzA3NDU3LzI4MDIxMjUyNS05ZDU1ZmQ3Zi0wY2FjLTQ2ZjAtOWY0Ny1jZDYwYWJhZTg2MzUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMTkxMTAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWEwNjc1ZGNlZWZjNDBmZDE3ZWM0OWE2NTIxODViMzQxZGMxOTg4MTg2NGI5NDVhYTUzM2ZkYzJjZDIwMGNjNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.bcn2QUFJprKnerQcQzGgKg2UEvqGm20sMiH9cZsjKAQ)
https://openmobilityfnd.stoplight.io/docs/mds-openapi/0f4cefcc4c183-trips
![image](https://private-user-images.githubusercontent.com/5707457/280212707-a3b05400-040c-4b0d-8e5b-f806d7750ea0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3OTg5NjAsIm5iZiI6MTcyMjc5ODY2MCwicGF0aCI6Ii81NzA3NDU3LzI4MDIxMjcwNy1hM2IwNTQwMC0wNDBjLTRiMGQtOGU1Yi1mODA2ZDc3NTBlYTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMTkxMTAwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDBlZDU2NWVmM2E2MGNkYmUwMDgyOTFmMTY3MDMyZDM3M2NlYjZmY2I0NDM2MmIwNDk2YjUxODhhMWM5NDVmOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UXA12wtCHtnf-n433LMQD76GqRVarySFG1FJ2Wg1T80)
The text was updated successfully, but these errors were encountered: