Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Gmsh brep import #59

Closed
akoen opened this issue Aug 25, 2023 · 3 comments
Closed

Simplify Gmsh brep import #59

akoen opened this issue Aug 25, 2023 · 3 comments

Comments

@akoen
Copy link

akoen commented Aug 25, 2023

OCC objects can be directly imported into Gmsh using a native pointer instead of exporting and importing a brep file.

https://github.com/openmsr/CAD_to_OpenMC/blob/18a138f0bf23d02ce95d48f79961f923031acd33/src/CAD_to_OpenMC/assemblymesher_gmsh.py#L92C21-L92C21

See Cad-to-DAGMC:
https://github.com/fusion-energy/cad_to_dagmc/blob/bf0243cb4f8de46d0958760a12b83610dedffdc5/src/cad_to_dagmc/brep_to_h5m.py#L32C6-L32C6
@ebknudsen
Copy link
Collaborator

Thanks for the comment - this is scheduled to happen in the overnext release.

ebknudsen added a commit to ebknudsen/CAD_to_openMC that referenced this issue Oct 9, 2023
@ebknudsen
simplify gmsh import (as suggested by akoen)
37aa015 
related to openmsr#59
@ebknudsen ebknudsen mentioned this issue Oct 9, 2023
Merged
@ebknudsen
Copy link
Collaborator

This fix will have to be postponed as originally intended as I can't seem to get it to work reliably right now. Reverting 37aa015 for now.

@ebknudsen
Copy link
Collaborator

closing as a wont fix for now. This should really be taken care of more generally as a solution to #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebknudsen @akoen