Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Precondition table needs too much memory with "too many ops" #241

Open
PtrMan opened this issue Nov 26, 2022 · 3 comments
Open

Design: Precondition table needs too much memory with "too many ops" #241

PtrMan opened this issue Nov 26, 2022 · 3 comments

Comments

@PtrMan
Copy link
Contributor

PtrMan commented Nov 26, 2022

How to reproduce? Set OPERATIONS_MAX to something like 15 or 32.

In Concept.h we have

 Table precondition_beliefs[OPERATIONS_MAX+1];

this causes OOM for machines with <1GB and default config for number of concepts.

@PtrMan
Copy link
Contributor Author

PtrMan commented Nov 26, 2022

One way which is compatible with the preallocation philosophy of memory managment is to add a custom memory allocator + manager under AIKR for entry's which are utilized.

@automenta
Copy link

This application ought to apply AIKR principles
https://cis.temple.edu/~pwang/Publication/AIKR.pdf

@patham9
Copy link
Member

patham9 commented Nov 27, 2022

"One way which is compatible with the preallocation philosophy of memory managment is to add a custom memory allocator + manager under AIKR for entry's which are utilized."

I agree it's quite space-wasting. Let's see how the stats look like, if the concepts have their implication tables full for most long-term runs it won't help much. While if most of them are quite empty, there will be great benefit of such an allocator. Let's see.

@patham9 patham9 changed the title Design: Precondition table needs to much memory with "to many ops" Design: Precondition table needs to much memory with "too many ops" Nov 27, 2022
@patham9 patham9 changed the title Design: Precondition table needs to much memory with "too many ops" Design: Precondition table needs too much memory with "too many ops" Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants