Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable declaration does not check input type #2

Open
stephteo opened this issue Oct 13, 2022 · 0 comments
Open

Variable declaration does not check input type #2

stephteo opened this issue Oct 13, 2022 · 0 comments

Comments

@stephteo
Copy link
Collaborator

stephteo commented Oct 13, 2022

For (possibly) all variables types (e.g. BoolVar, IntVar) etc, we do not do any type validation/conversion if the user tries to create a variable with a value that is not a boolean or integer.

Some suggests for cases where we should consider converting instead of failing:
BoolVar(1, "i") --> BoolVar(True, "i")
IntVar(1.0, "j") --> IntVar(1, "j")

There may also be some other cases where it would make more sense to warn & convert instead of failing.

@karalekas karalekas transferred this issue from another repository Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant