-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: testsuite #214
FIX: testsuite #214
Conversation
… should finally resolve annoying bus error in CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 23 23
Lines 4573 4573
=======================================
Hits 4206 4206
Misses 367 367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is frustrating. It seems that the nightly xarray test over in #213 works now. But there are more changes there wrt contextmanager. So I'll pull these changes here, too. |
82030e0
to
7f6164b
Compare
When running all tests in serial fashion, no bus error. There is something very strange going on with numpy.memmap and how we use the file fixtures for nexrad level2 files. I've removed one test (which is already in test_io.py) from nexrad_level2 tests and reinstated the --dist loadfile (runs all tests in one file in serial fashion). |
* use scope="session" for nexradlevel2_fixture to only be created once, should finally resolve annoying bus error in CI * use with-contextmanager to open_dataset in tests, minor fixes in the tests * remove unneeded test from test_nexrad_level2.py
… should finally resolve annoying bus error in CI