Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: testsuite #214

Merged
merged 5 commits into from
Oct 16, 2024
Merged

FIX: testsuite #214

merged 5 commits into from
Oct 16, 2024

Conversation

kmuehlbauer
Copy link
Collaborator

… should finally resolve annoying bus error in CI

… should finally resolve annoying bus error in CI
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (c998f25) to head (26ea0f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files          23       23           
  Lines        4573     4573           
=======================================
  Hits         4206     4206           
  Misses        367      367           
Flag Coverage Δ
notebooktests 78.24% <ø> (ø)
unittests 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator Author

This is frustrating. It seems that the nightly xarray test over in #213 works now. But there are more changes there wrt contextmanager. So I'll pull these changes here, too.

@kmuehlbauer
Copy link
Collaborator Author

When running all tests in serial fashion, no bus error. There is something very strange going on with numpy.memmap and how we use the file fixtures for nexrad level2 files.

I've removed one test (which is already in test_io.py) from nexrad_level2 tests and reinstated the --dist loadfile (runs all tests in one file in serial fashion).

@kmuehlbauer kmuehlbauer changed the title use scope="session" for nexradlevel2_fixture to only be created once FIX: testsuite Oct 16, 2024
@kmuehlbauer kmuehlbauer merged commit cd13dc1 into openradar:main Oct 16, 2024
11 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-fixture branch October 16, 2024 09:37
rcjackson pushed a commit to rcjackson/xradar that referenced this pull request Nov 26, 2024
* use scope="session" for nexradlevel2_fixture to only be created once, should finally resolve annoying bus error in CI
* use with-contextmanager to open_dataset in tests, minor fixes in the tests
* remove unneeded test from test_nexrad_level2.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant