Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not call sock::close when read timeout like redis.lua did? #71

Open
yyqbuct opened this issue Jan 18, 2018 · 1 comment
Open

why not call sock::close when read timeout like redis.lua did? #71

yyqbuct opened this issue Jan 18, 2018 · 1 comment

Comments

@yyqbuct
Copy link

yyqbuct commented Jan 18, 2018

why not call sock::close when read timeout like redis.lua did?

In redis.lua,the connection pool was destroyed when read timeout happens

SHA-1: c75af8fe7f71ca05e4bd3ccb3923f6a81d62a67a
bugfix: the memcached connection might enter a bad state when read timeout happens because ngx_lua's cosocket reading calls no longer automatically close the connection in this case.

so my question is why did not treat this as a bug in mysql.lua

thanks

@yyqbuct yyqbuct changed the title why did not call sock::close when read timeout like redis.lua did? why not call sock::close when read timeout like redis.lua did? Jan 18, 2018
@agentzh
Copy link
Member

agentzh commented Jan 19, 2018

@yyqbuct Seems like we need to port that fix over too. Pull requests welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants