-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auto Suggest] DQL Parsing updates and Fixes #8931
Open
paulstn
wants to merge
6
commits into
opensearch-project:main
Choose a base branch
from
paulstn:autosuggest-dql-bugs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+82
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to paulstn/OpenSearch-Dashboards
that referenced
this pull request
Nov 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8931 +/- ##
==========================================
- Coverage 60.88% 60.87% -0.01%
==========================================
Files 3802 3802
Lines 91072 91077 +5
Branches 14375 14377 +2
==========================================
+ Hits 55445 55447 +2
- Misses 32085 32086 +1
- Partials 3542 3544 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
paulstn
force-pushed
the
autosuggest-dql-bugs
branch
from
November 27, 2024 00:24
86d5b3d
to
db5a604
Compare
paulstn
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
November 27, 2024 00:27
paulstn
requested review from
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
November 27, 2024 00:27
paulstn
changed the title
[Auto Complete] DQL Parsing updates and Fixes
[Auto Suggest] DQL Parsing updates and Fixes
Nov 27, 2024
joshuali925
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: PR is based on #8275, can only be merged when the aforementioned isThey are relatively separate PRs, can decouple
Fixes DQL issues such as:
Screen.Recording.2024-11-26.at.4.30.11.PM.mov
:
) if the field is of type boolean or keyword, and suggest every other operator typeEvery file under
.generated
can be ignoredIssues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration