Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Suggest] DQL Parsing updates and Fixes #8931

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

paulstn
Copy link
Contributor

@paulstn paulstn commented Nov 26, 2024

Description

NOTE: PR is based on #8275, can only be merged when the aforementioned is
They are relatively separate PRs, can decouple

Fixes DQL issues such as:

  • DQL 'ID' definition, so that ANTLR can parse field names that contain an 'at' + slight adjustments
  • Putting double quotes on values to let ANTLR parse the query even if the values contain offending symbols
Screen.Recording.2024-11-26.at.4.30.11.PM.mov
  • Changing field to only add an EQ (:) if the field is of type boolean or keyword, and suggest every other operator type
    image

Every file under .generated can be ignored

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: DQL autocomplete better parsing and fixes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to paulstn/OpenSearch-Dashboards that referenced this pull request Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (8f58bce) to head (de97f8f).

Files with missing lines Patch % Lines
...c/plugins/data/public/antlr/dql/code_completion.ts 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8931      +/-   ##
==========================================
- Coverage   60.88%   60.87%   -0.01%     
==========================================
  Files        3802     3802              
  Lines       91072    91077       +5     
  Branches    14375    14377       +2     
==========================================
+ Hits        55445    55447       +2     
- Misses      32085    32086       +1     
- Partials     3542     3544       +2     
Flag Coverage Δ
Linux_1 29.01% <0.00%> (-0.01%) ⬇️
Linux_2 56.38% <ø> (ø)
Linux_3 37.89% <80.00%> (-0.01%) ⬇️
Linux_4 28.99% <0.00%> (-0.01%) ⬇️
Windows_1 29.03% <0.00%> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <80.00%> (+<0.01%) ⬆️
Windows_4 28.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

paulstn and others added 5 commits November 27, 2024 00:24
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn paulstn changed the title [Auto Complete] DQL Parsing updates and Fixes [Auto Suggest] DQL Parsing updates and Fixes Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants