Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto Suggest] SQL Syntax Highlighting fix #8951

Merged
merged 2 commits into from
Nov 27, 2024
Merged

[Auto Suggest] SQL Syntax Highlighting fix #8951

merged 2 commits into from
Nov 27, 2024

Conversation

paulstn
Copy link
Contributor

@paulstn paulstn commented Nov 27, 2024 •
edited
Loading

Description

Fixes SQL monaco monarch tokens by separating the states for single quoted and double quoted strings so that both can appear properly

Previously:

Screen.Recording.2024-11-26.at.4.44.26.PM.mov

Fixed:

Screen.Recording.2024-11-26.at.4.47.28.PM.mov

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: SQL syntax highlighting double quotes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@paulstn
separated string states to enter and leave quotes properly
b525c9f 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@paulstn paulstn changed the title [Auto Complete] SQL Syntax Highlighting fix [Auto Suggest] SQL Syntax Highlighting fix Nov 27, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (073a9ff) to head (94dbd42).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8951   +/-   ##
=======================================
  Coverage   60.87%   60.88%           
=======================================
  Files        3802     3802           
  Lines       91072    91072           
  Branches    14375    14375           
=======================================
+ Hits        55444    55446    +2     
+ Misses      32086    32085    -1     
+ Partials     3542     3541    -1
Flag Coverage Δ
Linux_1 29.02% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.90% <ø> (+<0.01%) ⬆️
Linux_4 29.00% <ø> (ø)
Windows_1 29.03% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <ø> (+<0.01%) ⬆️
Windows_4 29.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla merged commit 8f58bce into opensearch-project:main Nov 27, 2024
76 checks passed
@kavilla
Copy link
Member

kavilla commented Nov 27, 2024

@paulstn does this need to make it to a next branch?

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 27, 2024
@github-actions @opensearch-changeset-bot
[Auto Suggest] SQL Syntax Highlighting fix (#8951)
4fb2972 
Fixes SQL monaco monarch tokens by separating the states for single quoted and double quoted strings so that both can appear properly

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 8f58bce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 27, 2024
Open
@paulstn paulstn deleted the autosuggest-sql-monarch-fix branch November 27, 2024 18:55
@paulstn
Copy link
Contributor Author

paulstn commented Nov 27, 2024

@kavilla Not too sure what other branches it should be in, but it wasn't made to go into any other branch so probably no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x discover for discover reinvent discover-next seasoned-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulstn @kavilla @sejli