Vulnerability upgrades backwards compatibility #656
Conversation
| widget.value.translated=true | ||
| enable.backward.compatability=true |
There was a problem hiding this comment.
Rename this to easy_rule.v3.compatibility
There was a problem hiding this comment.
All changes mentioned are updated according the suggestion @ekigamba
| @@ -1428,11 +1428,12 @@ private Facts getEntries(String[] address, JSONObject object) throws JSONExcepti | |||
| formObject.put(RuleConstant.IS_RULE_CHECK, true); | |||
| formObject.put(RuleConstant.STEP, formObject.getString(RuleConstant.STEP)); | |||
|
|
|||
| if(Utils.enabledProperty(NativeFormsProperties.KEY.ENABLE_BACKWARD_COMPATIBILITY)) { | |||
There was a problem hiding this comment.
Go to Code > Reformat code to automatically fix any spacing eg after the if block to if (Utils...
| @@ -23,6 +23,7 @@ public final static class KEY { | |||
| //Widgets | |||
| public static final String WIDGET_DATEPICKER_IS_NUMERIC = "widget.datepicker.is.numeric"; | |||
| public static final String WIDGET_VALUE_TRANSLATED = "widget.value.translated"; | |||
| public static final String ENABLE_BACKWARD_COMPATIBILITY = "enable.backward.compatability"; | |||
There was a problem hiding this comment.
Rename this constant to EASY_RULES_V3_COMPATIBILITY
| @@ -31,7 +32,7 @@ public class DiskFileSource implements FormFileSource { | |||
| private MVELRuleFactory mvelRuleFactory; | |||
|
|
|||
| private DiskFileSource() { | |||
| this.mvelRuleFactory = new MVELRuleFactory(new YamlRuleDefinitionReaderExt()); | |||
| this.mvelRuleFactory = new MVELRuleFactory(new YamlRuleDefinitionReaderExt()); | |||
There was a problem hiding this comment.
Kindly make this optional by switching to YamlRuleDefinitionReader or YamlRuleDefinitionReaderExt
| @@ -26,7 +27,7 @@ public class AssetsFileSource implements FormFileSource { | |||
| private MVELRuleFactory mvelRuleFactory; | |||
|
|
|||
| private AssetsFileSource() { | |||
| this.mvelRuleFactory = new MVELRuleFactory(new YamlRuleDefinitionReaderExt()); | |||
| this.mvelRuleFactory = new MVELRuleFactory(new YamlRuleDefinitionReaderExt()); | |||
There was a problem hiding this comment.
Kindly make this optional by switching to YamlRuleDefinitionReader or YamlRuleDefinitionReaderExt
| @@ -1939,6 +1940,7 @@ private List<String> getRules(String filename, String fieldKey, boolean readAllR | |||
|
|
|||
| StringBuilder conditionString = new StringBuilder(); | |||
| conditionString.append(map.get(RuleConstant.CONDITION).toString()); | |||
| boolean backwardCompatibility = Utils.enabledProperty(NativeFormsProperties.KEY.ENABLE_BACKWARD_COMPATIBILITY); | |||
There was a problem hiding this comment.
Rename this variable to be more accurate eg jEasyRulesV3Compatible
|
@junaidwarsivd We can merge this into #655 and I can review the requested changes from #655 |
No description provided.