Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you provide an interface to inject a amdZip or ZipEntry? #3

Open
ChristianJunghans opened this issue Sep 10, 2015 · 0 comments
Open

Comments

@ChristianJunghans
Copy link

Hi,

I am using your library to parse a manifest and I already have a zip because the apk is uploaded into a service. So I create the zip on the fly from the postet data.

currently I do this:

var admZip = require('adm-zip');
var ApkReader = require('adbkit-apkreader');

var zip = new admZip(blob);
var reader = new ApkReader(null);
reader.zip = zip;
var manifest = reader.readManifestSync();

This works but as soon as you change something internally it will break.

So I suggest to add an optional parameter zip to the readManifestSync function. If it is set, the function could read the provided zip if not the one of the class.

Regards
Christian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant