Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use highway=busway instead of emergency=yes when determining feature type in query results #5258

Open
tguen opened this issue Oct 12, 2024 · 7 comments
Labels
good first issue Issues that require little knowledge of the codebase i18n Internationalisation - related to translation into different languages

Comments

@tguen
Copy link

tguen commented Oct 12, 2024

Problem

In query results, features with highway=busway and emergency=yes are listed only as "yes" in query results.

For example, this one shown below.

Description

No response

Screenshots

busway

@mmd-osm mmd-osm added the good first issue Issues that require little knowledge of the codebase label Oct 13, 2024
@mmd-osm
Copy link
Contributor

mmd-osm commented Oct 13, 2024

New entry for highway=busway to be added here: https://github.com/openstreetmap/openstreetmap-website/blob/master/config/locales/en.yml#L920

image

@mmd-osm
Copy link
Contributor

mmd-osm commented Oct 13, 2024

According to https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#nominatim-prefixes, "I18n keys under the geocoder.search_osm_nominatim" are managed by Nominatim maintainers.

I'm not exactly clear how this was done in the past. Maybe @lonvia can help here.

@lonvia
Copy link
Contributor

lonvia commented Oct 14, 2024

Feel free to add new entries. And feel free to make a PR to get of this section in CONTRIBUTING.md.

mmd-osm added a commit to mmd-osm/openstreetmap-website that referenced this issue Oct 14, 2024
mmd-osm added a commit to mmd-osm/openstreetmap-website that referenced this issue Oct 14, 2024
@gravitystorm gravitystorm added the i18n Internationalisation - related to translation into different languages label Oct 16, 2024
@prasathsarath
Copy link

@tguen / @gravitystorm / @lonvia : I will work on this issue, please assign this to me

@HolgerJeromin
Copy link
Contributor

Not all projects work with assignments. Especially to new contributors. This can result in cookie licking.
Go ahead, get familiar to the code base and work on this if you like.
If you solve this. Hurray!

prasathsarath added a commit to prasathsarath/openstreetmap-website that referenced this issue Nov 14, 2024
Yatharths11 pushed a commit to Yatharths11/openstreetmap-website that referenced this issue Nov 30, 2024
@psy-duck1
Copy link

Hey there, i'm interested in this issue will you please assign this to me.

@hlfan
Copy link
Contributor

hlfan commented Dec 14, 2024

You don't need to be assigned to work on this, as already pointed out:

Not all projects work with assignments. Especially to new contributors. This can result in cookie licking.
Go ahead, get familiar to the code base and work on this if you like.
If you solve this. Hurray!

And you can even take a look at #5321 and #5361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that require little knowledge of the codebase i18n Internationalisation - related to translation into different languages
Projects
None yet
Development

No branches or pull requests

8 participants