-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues regarding ucc_coll_args::tag #893
Comments
Hi @nirandaperera, I think it's bug in documentation. Currently "tag" exists only in API, no TLs in UCC support it and it would be difficult to implement 64 bit tags. @manjugv can you please take a look. |
@Sergei-Lebedev so does it mean that none of the tls currently support unordered collectives? |
yes, it was added to API for future use. |
It seems like the It seems to be copied to |
https://github.com/openucx/ucc/blob/master/src/components/tl/ucp/tl_ucp_tag.h#L16 |
Yes, this message tag is used to correctly schedule send/recv operations along with source rank and team id. TL UCP generates tag when user doesn't provide it. The idea is if user gives us a tag we don't generate but use whatever user gives us. Apparently it should work only with TL UCP. |
The docs mention that a collective tag is a 64-bit integer.
ucc/docs/doxygen/collectives.md
Line 148 in a7e46ee
But
ucc_coll_args.tag
is atypedef uint16_t ucc_coll_id_t
type. Do you know if this is a bug or intentional?Also, should the tag be unique to the collective operation individually, or should it be unique to all collective operations globally?
The text was updated successfully, but these errors were encountered: