diff --git a/CHANGELOG.md b/CHANGELOG.md index b74112b0ea..9a364894c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1294,7 +1294,7 @@ async with profile.session() as session: - Various documentation and bug fixes - Add admin routes for fetching and accepting the ledger transaction author agreement [#144](https://github.com/hyperledger/aries-cloudagent-python/pull/144) - Add support for receiving connection-less proof presentations [#296](https://github.com/hyperledger/aries-cloudagent-python/pull/296) -- Set attachment id explicitely in unbound proof request [#289](https://github.com/hyperledger/aries-cloudagent-python/pull/289) +- Set attachment id explicitly in unbound proof request [#289](https://github.com/hyperledger/aries-cloudagent-python/pull/289) - Add create-proposal admin endpoint to the present-proof protocol [#288](https://github.com/hyperledger/aries-cloudagent-python/pull/288) - Remove old anon/authcrypt support [#282](https://github.com/hyperledger/aries-cloudagent-python/pull/282) - Allow additional endpoints to be specified [#276](https://github.com/hyperledger/aries-cloudagent-python/pull/276) diff --git a/Endorser.md b/Endorser.md index b1db873c26..d4961b5196 100644 --- a/Endorser.md +++ b/Endorser.md @@ -2,7 +2,7 @@ ACA-Py supports an [Endorser Protocol](https://github.com/hyperledger/aries-rfcs/pull/586), that allows an un-privileged agent (an "Author") to request another agent (the "Endorser") to sign their transactions so they can write these transactions to the ledger. This is required on Indy ledgers, where new agents will typically be granted only "Author" privileges. -Transaction Endorsement is built into the protocols for Schema, Credential Definition and Revocation, and endorsements can be explicitely requested, or ACA-Py can be configured to automate the endorsement workflow. +Transaction Endorsement is built into the protocols for Schema, Credential Definition and Revocation, and endorsements can be explicitly requested, or ACA-Py can be configured to automate the endorsement workflow. ## Setting up Connections between Authors and Endorsers @@ -12,7 +12,7 @@ Once the connection is established and `active`, the "role" (either Author or En ## Requesting Transaction Endorsement -Transaction Endorsement is built into the protocols for Schema, Credential Definition and Revocation. When executing one of the endpoints that will trigger a ledger write, an endorsement protocol can be explicitely requested by specifying the `connection_id` (of the Endorser connection) and `create_transaction_for_endorser`. +Transaction Endorsement is built into the protocols for Schema, Credential Definition and Revocation. When executing one of the endpoints that will trigger a ledger write, an endorsement protocol can be explicitly requested by specifying the `connection_id` (of the Endorser connection) and `create_transaction_for_endorser`. (Note that endorsement requests can be automated, see the secion on "Configuring ACA-Py" below.) diff --git a/aries_cloudagent/commands/start.py b/aries_cloudagent/commands/start.py index d9497c04b3..c74b8d3a79 100644 --- a/aries_cloudagent/commands/start.py +++ b/aries_cloudagent/commands/start.py @@ -49,7 +49,7 @@ def execute(argv: Sequence[str] = None): settings = get_settings(args) common_config(settings) - # set ledger to read only if explicitely specified + # set ledger to read only if explicitly specified settings["ledger.read_only"] = settings.get("read_only_ledger", False) # Create the Conductor instance diff --git a/aries_cloudagent/resolver/did_resolver.py b/aries_cloudagent/resolver/did_resolver.py index a25576254c..1186e2c6ce 100644 --- a/aries_cloudagent/resolver/did_resolver.py +++ b/aries_cloudagent/resolver/did_resolver.py @@ -122,7 +122,7 @@ async def _match_did_to_resolver( ) resolvers = list(chain(native_resolvers, non_native_resolvers)) if not resolvers: - raise DIDMethodNotSupported(f'No resolver supprting DID "{did}" loaded') + raise DIDMethodNotSupported(f'No resolver supporting DID "{did}" loaded') return resolvers async def dereference( diff --git a/aries_cloudagent/utils/tracing.py b/aries_cloudagent/utils/tracing.py index ca13ac0a01..738ee3c108 100644 --- a/aries_cloudagent/utils/tracing.py +++ b/aries_cloudagent/utils/tracing.py @@ -47,7 +47,7 @@ def get_timer() -> float: def tracing_enabled(context, message) -> bool: """Determine whether to log trace messages or not.""" - # check if tracing is explicitely on + # check if tracing is explicitly on if context.get("trace.enabled"): return True diff --git a/demo/AliceWantsAJsonCredential.md b/demo/AliceWantsAJsonCredential.md index e5afad3213..f387a130b8 100644 --- a/demo/AliceWantsAJsonCredential.md +++ b/demo/AliceWantsAJsonCredential.md @@ -78,7 +78,7 @@ You do *not* create a schema or cred def for a JSON-LD credential (these are onl You will need to create a DID as above for Alice as well (`/wallet/did/create` etc ...). -Congradulations, you are now ready to start issuing JSON-LD credentials! +Congratulations, you are now ready to start issuing JSON-LD credentials! - You have two agents with a connection established between the agents - you will need to copy Faber's `connection_id` into the examples below. - You have created a (non-public) DID for Faber to use to sign/issue the credentials - you will need to copy the DID that you created above into the examples below (as `issuer`). diff --git a/demo/README.md b/demo/README.md index b3f05c99fb..2f91d3adf6 100644 --- a/demo/README.md +++ b/demo/README.md @@ -216,7 +216,7 @@ To enable support for revoking credentials, run the `faber` demo with the `--rev ./run_demo faber --revocation ``` -Note that you don't specify this option with `alice` because it's only applicable for the credential `issuer` (who has to enable revocation when creating a credential definition, and explicitely revoke credentials as appropriate; alice doesn't have to do anything special when revocation is enabled). +Note that you don't specify this option with `alice` because it's only applicable for the credential `issuer` (who has to enable revocation when creating a credential definition, and explicitly revoke credentials as appropriate; alice doesn't have to do anything special when revocation is enabled). You need to run an AnonCreds revocation registry tails server in order to support revocation - the details are described in the [Alice gets a Phone](https://github.com/hyperledger/aries-cloudagent-python/blob/master/demo/AliceGetsAPhone.md#run-an-instance-of-indy-tails-server) demo instructions. diff --git a/demo/docker-agent/README.md b/demo/docker-agent/README.md index c5fb56dc59..e5bd454ae2 100644 --- a/demo/docker-agent/README.md +++ b/demo/docker-agent/README.md @@ -51,7 +51,7 @@ For example start the endorser service as `LEDGER_URL=http://test.bcovrin.vonx.i ### Connecting the Author to the Endorser -Endorser Service: Use the `GET /v1/admin/config` endpoint to fetch the endorser's configuration, including the public DID (which the author will need to know). Also confirm whether the `ENDORSER_AUTO_ACCEPT_CONNECTIONS` and `ENDORSER_AUTO_ENDORSE_REQUESTS` settings are `True` or `False` - for the following we will assume that both are `False` and the endorser must explicitely respond to all requests. +Endorser Service: Use the `GET /v1/admin/config` endpoint to fetch the endorser's configuration, including the public DID (which the author will need to know). Also confirm whether the `ENDORSER_AUTO_ACCEPT_CONNECTIONS` and `ENDORSER_AUTO_ENDORSE_REQUESTS` settings are `True` or `False` - for the following we will assume that both are `False` and the endorser must explicitly respond to all requests. Author Agent: Use the `POST /didexchange/create-request` to request a connection with the endorser, using the endorser's public DID. Set the `alias` to `Endorser` - this *MUST* match the `--endorser-alias 'Endorser'` setting (in the ngrok-wait.sh script). Use the `GET /connections` endpoint to verify the connection is in `request` state.