-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[change] SAML should create EmailAddress objects #523
Labels
enhancement
New feature or request
Comments
kaushikaryan04
added a commit
to kaushikaryan04/openwisp-radius
that referenced
this issue
Jul 27, 2024
- Check if the NameID is an email and use it as the user's email. - If NameID is not an email, check for the 'email' attribute in the SAML response. - Create an EmailAddress object using the retrieved email. Fixes openwisp#523
kaushikaryan04
added a commit
to kaushikaryan04/openwisp-radius
that referenced
this issue
Jul 27, 2024
- Check if the NameID is an email and use it as the user's email. - If NameID is not an email, check for the 'email' attribute in the SAML response. - Create an EmailAddress object using the retrieved email. Fixes openwisp#523
4 tasks
kaushikaryan04
added a commit
to kaushikaryan04/openwisp-radius
that referenced
this issue
Aug 8, 2024
-Added Validation for email -If validation is failed we try to get email from attributes -Added tests to see if Exception is raised when invalid mail is provided Fixes openwisp#523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The SAML authentication of this module does not create
EmailAddress
objects, which is problematic because we are gradually changing the entire application to send notification emails to verified addresses only.Therefore we should proceed to make sure SAML auth creates
EmailAddress
objects and always flags the email coming from SAML as verified and primary.The text was updated successfully, but these errors were encountered: