Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] delete_old_radiusbatch_users management command is inconsistent #525

Open
pandafy opened this issue Jun 10, 2024 · 0 comments · May be fixed by #527
Open

[change] delete_old_radiusbatch_users management command is inconsistent #525

pandafy opened this issue Jun 10, 2024 · 0 comments · May be fixed by #527

Comments

@pandafy
Copy link
Member

pandafy commented Jun 10, 2024

The delete_old_radiusbatch_users management command expects the argument to be present in months while all the other management commands requires the argument in days.

This inconsistency may lead to misconfiguration. We shall update the delete_old_radiusbatch_users command to accept days instead of months.
kaushikaryan04 added a commit to kaushikaryan04/openwisp-radius that referenced this issue Jun 30, 2024
@kaushikaryan04
[change] delete_old_radiusbatch_users management command is inconsist…
5ea9ee8 
…ent openwisp#525

changed the delete_old_radiusbatch_users management command to use days instead of months also modified tasks and tests to use days.

Fixes openwisp#525
kaushikaryan04 added a commit to kaushikaryan04/openwisp-radius that referenced this issue Jun 30, 2024
@kaushikaryan04
[change] Changed the delete_old_radiusbatch_users command to use days…
979e88a 
… instead of months openwisp#525

Changed the delete_old_radiusbatch_users command to take in days in argument instead of months and modified tests and tasks accordingly.

Fixes openwisp#525
kaushikaryan04 added a commit to kaushikaryan04/openwisp-radius that referenced this issue Jul 9, 2024
@kaushikaryan04
[change] Changed the delete_old_radiusbatch_users command to use days…
c755252 
… as well openwisp#525

Added the option to delete users by specifying days or months.If nothing is provided 18 months will be taken as default.

Fixes openwisp#525
kaushikaryan04 added a commit to kaushikaryan04/openwisp-radius that referenced this issue Jul 20, 2024
@kaushikaryan04
[change] Made the suggested changes and edited the testcase openwisp#525
a9af7a0 


Made the suggested changes and added the testcase so both old and new command could be tested.

Fixes openwisp#525
@pandafy pandafy linked a pull request Oct 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
OpenWISP Contributor's Board
Status: To do (Python & Django)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues/525 fix management command inconsistency kaushikaryan04/openwisp-radius
1 participant
@pandafy