New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Make batch import atomic #551

Open

nemesifier opened this issue Sep 13, 2024 · 0 comments

Labels

Member

nemesifier commented Sep 13, 2024

I was reviewing the batch CSV import code due to #550 and it seems to me the create operation is not atomic.

What if the import operation fails in the middle?

I believe we would end up with half users created.

I think it's better to make everything run in a transaction and if anything fails rollback.

nemesifier added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment