Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-dashboard: Fix the firmware version misalignment #7468

Open
1 task done
JoeDoe-X opened this issue Dec 12, 2024 · 8 comments
Open
1 task done

luci-mod-dashboard: Fix the firmware version misalignment #7468

JoeDoe-X opened this issue Dec 12, 2024 · 8 comments

Comments

@JoeDoe-X
Copy link

JoeDoe-X commented Dec 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

screenshots or captures

Shot_eng

Actual behaviour

Please correct the layout of the "System" tile. The "Firmware version" line cannot fit the long name and wraps the last character "e".

Expected behaviour

Fix this issue

Steps to reproduce

Go to Dashboard (x.x.x.x.x/cgi-bin/luci/admin/dashboard)

Additional Information

OpenWrt 23.05

What browsers do you see the problem on?

No response

Relevant log output

No response

@JoeDoe-X JoeDoe-X changed the title Luci: dashboard Luci: Dashboard Dec 12, 2024
@dannil
Copy link
Contributor

dannil commented Dec 12, 2024

#7366 solves the same problem for the model, we should be able to extend that to the firmware version.

@JoeDoe-X
Copy link
Author

#7366 is it the same problem with long name of device. Maybe small letter or wider frame solve the issue?

@JoeDoe-X JoeDoe-X changed the title Luci: Dashboard Luci: Dashboard Fix the firmware version misalignment Dec 12, 2024
@JoeDoe-X JoeDoe-X changed the title Luci: Dashboard Fix the firmware version misalignment luci-mod-dashboard: Fix the firmware version misalignment Dec 12, 2024
@dannil
Copy link
Contributor

dannil commented Dec 12, 2024

The correct solution for your specific issue would be to combine it with that PR and simply removing word-break: break-all from the CSS selector, I'm a bit puzzled why that's there in the first place.

With word-break: break-all:
Screenshot_17

Without word-break: break-all, which wouldn't wrap the character e in your example:
Screenshot_18

EDIT: I probably didn't explain it enough but all the values in the right column share the same word-break: break-all behaviour, so the wrapping issue would show up in Model, Firmware version, Architecture etc as well.

@systemcrash
Copy link
Contributor

@dannil could you make a PR? It would supersede the other one which might be problematic.

@dannil
Copy link
Contributor

dannil commented Dec 12, 2024

@dannil could you make a PR? It would supersede the other one which might be problematic.

I can look into it cause I agree that just setting display: inline-flex isn't the correct solution, the CSS is a bit of a mess for the dashboard so it may need some more changes to the layout to actually behave correctly.

EDIT: here's an example with the Firmware version as well just as @JoeDoe-X pointed out where it incorrectly line-breaks the revision, just to illustrate that it exists for all columns.

Screenshot_19

@systemcrash
Copy link
Contributor

ping for @dannil :)

@dannil
Copy link
Contributor

dannil commented Dec 27, 2024

Yup still in the backlog ;)

@wetxxx
Copy link

wetxxx commented Dec 30, 2024

Which files will be change after this? I will be waiting for OpenWrt Files update (..../cgi-bin/luci/admin/system/opkg).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants