From e203222baef2615ea8c407b8b17cc23632114bf7 Mon Sep 17 00:00:00 2001 From: Vipul Date: Mon, 9 Dec 2024 21:49:15 -0800 Subject: [PATCH] review comments --- ads/aqua/evaluation/evaluation.py | 10 ++++------ ads/aqua/finetuning/finetuning.py | 10 ++++------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/ads/aqua/evaluation/evaluation.py b/ads/aqua/evaluation/evaluation.py index c4585819d..c235e8143 100644 --- a/ads/aqua/evaluation/evaluation.py +++ b/ads/aqua/evaluation/evaluation.py @@ -543,12 +543,10 @@ def create( ), ), tags={ - **{ - "aqua_evaluation": Tags.AQUA_EVALUATION, - "evaluation_job_id": evaluation_job.id, - "evaluation_source": create_aqua_evaluation_details.evaluation_source_id, - "evaluation_experiment_id": experiment_model_version_set_id, - }, + "aqua_evaluation": Tags.AQUA_EVALUATION, + "evaluation_job_id": evaluation_job.id, + "evaluation_source": create_aqua_evaluation_details.evaluation_source_id, + "evaluation_experiment_id": experiment_model_version_set_id, **evaluation_model_freeform_tags, **evaluation_model_defined_tags, }, diff --git a/ads/aqua/finetuning/finetuning.py b/ads/aqua/finetuning/finetuning.py index e1457b3f4..d8c2e9bc0 100644 --- a/ads/aqua/finetuning/finetuning.py +++ b/ads/aqua/finetuning/finetuning.py @@ -477,12 +477,10 @@ def create( ), ), tags={ - **{ - "aqua_finetuning": Tags.AQUA_FINE_TUNING, - "finetuning_job_id": ft_job.id, - "finetuning_source": source.id, - "finetuning_experiment_id": experiment_model_version_set_id, - }, + "aqua_finetuning": Tags.AQUA_FINE_TUNING, + "finetuning_job_id": ft_job.id, + "finetuning_source": source.id, + "finetuning_experiment_id": experiment_model_version_set_id, **model_freeform_tags, **model_defined_tags, },