Fixes the validation of acceptable model types for registration in AQUA. #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrDzurb
requested review from
darenr,
mayoor,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
darenr
previously approved these changes
Sep 30, 2024
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
mayoor
reviewed
Oct 2, 2024
ads/aqua/extension/model_handler.py
Outdated
| if ( | ||
| not hf_model_info.pipeline_tag | ||
| or hf_model_info.pipeline_tag.lower() != ModelTask.TEXT_GENERATION | ||
| if not ( |
There was a problem hiding this comment.
In some case the pipeline_tag is empty. We should allow registration when pipeline is empty. I am wondering if we should just remove this restriction all together.
There was a problem hiding this comment.
Yes, I agree. Will remove the validation
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
approved these changes
Oct 9, 2024
mayoor
approved these changes
Oct 9, 2024
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the validation of acceptable model types for registration in AQUA.