Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include secret leak detection in the template feature branch pipeline (sync-feature-branches) #207

Open
gberche-orange opened this issue Oct 23, 2018 · 4 comments

Comments

@gberche-orange
Copy link
Member

**Is your feature request related to a problem?

I need to prevent introduction of secrets leaks into the template repo. This is a follow up of initial effort in
https://github.com/orange-cloudfoundry/paas-templates/issues/4

Describe the solution you'd like

sync-feature-branches to include secrets prevention tasks, and to fail when secrets are detected

Describe alternatives you've considered

Notification of the failed micro-depls-auto-sanitize pipeline.

@o-orand
Copy link
Member

o-orand commented Oct 23, 2018

For me, it seems more relevant to include this as a paas-templates pipeline, as secrets detection is already included in that repo.

@gberche-orange
Copy link
Member Author

@o-orand

Can you suggest a way such a paas-template pipeline can fail the sync-feature-branches and force authors to fix leaking secrets before they get merged ?

@o-orand
Copy link
Member

o-orand commented Jan 8, 2019

we are using a different pipeline (part of paas-template) to set our internal gitlab merge request status to failure

image

Here is a pipeline overview:
image

@gberche-orange
Copy link
Member Author

Current status: the introduction of credentials leaks in new features is notified through gitlab merge request status. It is not blocking merge of related feature branch into develop branch and release.

Risks:

  • Introduction of credentials leak in new contributions (i.e. new credentials are hardcoded and not stored into credhub). This exposes operators running these features.
  • Credentials leak on github.

Prioritized temporary workaround:

  • add manual step in release process to block release when new credentials leak are introduced
  • keep github publication with sanitization pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants