Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDIKitSMF: slow parse time for very big SMF files #208

Open
2 tasks done
mistydemeo opened this issue May 4, 2024 · 2 comments
Open
2 tasks done

MIDIKitSMF: slow parse time for very big SMF files #208

mistydemeo opened this issue May 4, 2024 · 2 comments
Labels
🎩 refinement An enhancement to an existing feature 🎹 smf MIDIKit SMF (Standard MIDI File)

Comments

@mistydemeo
Copy link
Contributor

Please Confirm

  • I have reviewed the MIDIKit Documentation which contains descriptive guides and extensive API reference
  • I have searched Issues and Discussions to see if the same question has already been asked

macOS Version(s) Used to Build

macOS 13 Ventura

Xcode Version(s)

Xcode 14

Description

I'm trying out MIDIKit for the first time, and noticed that parse/load times for very large SMF files seems to be longer than I'd expect. The file I'm loading is 820KB, with 17 MIDI chunks (2097 measures). A test program that consists solely of MIDIFile(midiFile: path) takes about 3.2 seconds to complete in a release build. (Small files are fairly quick to load.)

I recognize that this MIDI is... long... by most standards, so I understand you might not have optimized around it.

Crash Logs, Screenshots or Other Attachments (if applicable)

No response

@orchetect
Copy link
Owner

This is a known issue. No timeline yet for optimizing the MIDI file module but it's on the to-do list before version 1.0.0.

@mistydemeo
Copy link
Contributor Author

Aha! Good to know, thank you!

@orchetect orchetect added 🎹 smf MIDIKit SMF (Standard MIDI File) 🎩 refinement An enhancement to an existing feature labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎩 refinement An enhancement to an existing feature 🎹 smf MIDIKit SMF (Standard MIDI File)
Projects
None yet
Development

No branches or pull requests

2 participants